Skip to content

[stable24] fix(dav): Abort requests with 429 instead of waiting - #39254

Merged
nickvergessen merged 3 commits into
stable24from
backport/38046/stable24
Jul 11, 2023
Merged

[stable24] fix(dav): Abort requests with 429 instead of waiting#39254
nickvergessen merged 3 commits into
stable24from
backport/38046/stable24

Conversation

@nickvergessen

Copy link
Copy Markdown
Member

Backport #38046

Signed-off-by: Joas Schilling <coding@schilljs.com>
// set ownCloud namespace
$errorNode->setAttribute('xmlns:o', self::NS_OWNCLOUD);

$error = $errorNode->ownerDocument->createElementNS('o:', 'o:hint', 'too many requests');

Check notice

Code scanning / Psalm

PossiblyNullReference

Cannot call method createElementNS on possibly null value
kesselband others added 2 commits July 10, 2023 14:31
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
…analysis-security
Signed-off-by: Joas Schilling <coding@schilljs.com>
@kesselb

Copy link
Copy Markdown
Contributor

Cherry-picked 2e1ba10 for happy psalm 🙏

@kesselbkesselb added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jul 10, 2023
@nickvergessen
nickvergessen merged commit e65b577 into stable24Jul 11, 2023
@nickvergessen
nickvergessen deleted the backport/38046/stable24 branch July 11, 2023 04:43
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to releaseReady to be released and/or waiting for tests to finish

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@nickvergessen@kesselb@juliusknorr@mejo-@bigcat88@github-advanced-security