Uh oh!
There was an error while loading. Please reload this page.
[stable23] fix(dav): Abort requests with 429 instead of waiting - #39255
Merged
Conversation
Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
requested review from
ChristophWurst, julien-nc, juliusknorr and kesselbJuly 10, 2023 04:44
| // set ownCloud namespace | ||
| $errorNode->setAttribute('xmlns:o', self::NS_OWNCLOUD); | ||
| $error = $errorNode->ownerDocument->createElementNS('o:', 'o:hint', 'too many requests'); |
Check notice
Code scanning / Psalm
PossiblyNullReference
bigcat88
approved these changes
Jul 10, 2023
mejo-
approved these changes
Jul 10, 2023
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
Signed-off-by: Joas Schilling <coding@schilljs.com>
kesselb
commented
Jul 10, 2023
Contributor
The view, when the request is rejected, looks a bit weird. Otherwise fine. |
kesselb
approved these changes
Jul 10, 2023
juliusknorr
approved these changes
Jul 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #38046