Skip to content

cloud_federation_api: Add OpenAPI spec - #39318

Merged
provokateurin merged 2 commits into
masterfrom
feature/openapi/cloud_federation_api
Jul 13, 2023
Merged

cloud_federation_api: Add OpenAPI spec#39318
provokateurin merged 2 commits into
masterfrom
feature/openapi/cloud_federation_api

Conversation

@provokateurin

Copy link
Copy Markdown
Member

Summary

From #36666. Adds the necessary annotations and descriptions.

Also fixes some problems with responses that were not compliant with the spec at https://github.com/cs3org/OCM-API/blob/v1.0.0/spec.yaml.

Checklist

Signed-off-by: jld3103 <jld3103yt@gmail.com>
Signed-off-by: jld3103 <jld3103yt@gmail.com>
@provokateurin
provokateurinforce-pushed the feature/openapi/cloud_federation_api branch from 8f7ea56 to 6843bcdCompareJuly 13, 2023 05:21

@mejo-mejo- left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Despite being the main maintainer for this app since some weeks, I have to admit that I have zero clue about it so far. Code changes look legit to me with a minor comment.

@provokateurin
provokateurin merged commit b6e73c8 into masterJul 13, 2023
@provokateurin
provokateurin deleted the feature/openapi/cloud_federation_api branch July 13, 2023 06:18
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@provokateurin@mejo-@bigcat88