Uh oh!
There was an error while loading. Please reload this page.
[stable27] fix(files): sanitize name and ext display - #39333
Merged
Conversation
skjnldsv
requested review from
nfebe, susnux and szaimen
and removed request for
a teamJuly 12, 2023 11:53
skjnldsv
commented
Jul 12, 2023
MemberAuthor
/compile amend / |
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
nextcloud-commandforce-pushed
the
backport/38950/stable27
branch
from
July 12, 2023 12:05
f6d3451 to
ea37d1aComparesusnux
reviewed
Jul 12, 2023
| <span class="files-list__row-name-text">{{ displayName }}</span> | ||
| <span class="files-list__row-name-text"> | ||
| <!-- Keep the displayName stuck to the extension to avoid whitespace rendering issues--> | ||
| <span class="files-list__row-name-name" v-text="displayName" /> |
Contributor
There was a problem hiding this comment.
We use the mustache notation everywhere else, sure we want to mix with the v-text notation?
MemberAuthor
There was a problem hiding this comment.
Yes, because otherwise we have whitespace in the output too.
Vue does NOT trim whitespace. And for this specific example, we want to have none rendered. :)
susnux
approved these changes
Jul 12, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of 28c2d9e from #38950