Uh oh!
There was an error while loading. Please reload this page.
fix: Correctly add module content type to script tags with versions - #39456
Merged
Conversation
…with versions are used Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
requested review from
a team, ArtificialOwl, icewind1991, nfebe and szaimen
and removed request for
a teamJuly 18, 2023 11:12
susnux
commented
Jul 18, 2023
ContributorAuthor
/backport to stable27 |
26 tasks
szaimen
approved these changes
Jul 18, 2023
szaimen
left a comment
Contributor
There was a problem hiding this comment.
Tested and makes nextcloud/logreader#936 work :)
come-nc
approved these changes
Jul 18, 2023
susnux
commented
Jul 18, 2023
ContributorAuthor
Drone failure seems unrelated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When server is in production mode, scripts will be have a version query (
...?v=....), in this case module js script were not delivered with themodulecontent type.Checklist