Uh oh!
There was an error while loading. Please reload this page.
fix(IParallelAwareJob): Check for other reserved jobs before setting new ones as reserved - #39473
Merged
Conversation
marcelklehr
requested review from
a team, ArtificialOwl, come-nc, icewind1991 and szaimen
and removed request for
a teamJuly 19, 2023 09:40
marcelklehr
commented
Jul 19, 2023
MemberAuthor
/backport to stable27 |
come-nc
reviewed
Jul 20, 2023
Uh oh!
There was an error while loading. Please reload this page.
marcelklehrforce-pushed
the
fix/parallel-aware-job
branch
from
July 20, 2023 11:33
be77eca to
3c3241aComparemarcelklehr
commented
Jul 20, 2023
MemberAuthor
Added tests. |
come-nc
reviewed
Jul 20, 2023
Uh oh!
There was an error while loading. Please reload this page.
marcelklehr
commented
Jul 21, 2023
| $update = $this->connection->getQueryBuilder(); | ||
| $update->update('jobs') | ||
| ->set('last_checked', $update->createNamedParameter($this->timeFactory->getTime() + 1)) |
MemberAuthor
There was a problem hiding this comment.
+1 to avoid infinite loop
marcelklehr
commented
Jul 27, 2023
MemberAuthor
CI failure seems unrelated. |
miaulalala
approved these changes
Jul 27, 2023
bigcat88
approved these changes
Jul 27, 2023
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
marcelklehrforce-pushed
the
fix/parallel-aware-job
branch
from
July 28, 2023 09:12
d734da6 to
7e790a3Comparemarcelklehr
enabled auto-merge
July 28, 2023 09:12
nickvergessen
disabled auto-merge
July 28, 2023 11:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When setting
allowParallelJobstofalse, it checks whether other jobs with the same class are already reserved. This is always the case though, because we wait with this check until after setting the current job to reserved. This PR changes this order.Checklist