Uh oh!
There was an error while loading. Please reload this page.
/ocs/v1.php/cloud/groupsUPDATE method - correct status when group not found - #39537
Merged
Conversation
Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
/ocs/v1.php/cloud/groupsUPDATE method - correct status when group not foundsusnux
requested review from
a team, ArtificialOwl, icewind1991 and nfebe
and removed request for
a teamJuly 22, 2023 23:29
nfebe
reviewed
Jul 22, 2023
| if ($key === 'displayname') { | ||
| $group = $this->groupManager->get($groupId); | ||
| if ($group === null) { | ||
| throw new OCSException('Group does not exist', OCSController::RESPOND_NOT_FOUND); |
Contributor
There was a problem hiding this comment.
Suggested change
| thrownewOCSException('Group does not exist', OCSController::RESPOND_NOT_FOUND); | |
| thrownewOCSException("Group $groupIddoes not exist", OCSController::RESPOND_NOT_FOUND); |
Is probably more helpful.
MemberAuthor
There was a problem hiding this comment.
But the caller already knows what group he requested to edit.
marcelklehr
approved these changes
Jul 24, 2023
julien-nc
approved these changes
Jul 24, 2023
bigcat88
commented
Jul 27, 2023
MemberAuthor
/backport to stable27 |
bigcat88
commented
Jul 27, 2023
MemberAuthor
/backport to stable26 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We should return
OCSController::RESPOND_NOT_FOUNDwhen something from input parameters not found and set text description what exactly was not found.Checklist