AI admin settings by marcelklehr · Pull Request #39567 · nextcloud/server

marcelklehr · 2023-07-25T12:25:26Z

Resolves: -
Follow up on Introduce LanguageModel/TextProcessing OCP API #38854

Summary

Adds an admin settings section for AI settings, allowing admins to specify the precedence of machine translation providers, set the speech-to-text provider to use and select which text processing provider to use for which task.

Checklist

Code is properly formatted
Sign-off message is added to all commits
Tests (unit, integration, api and/or acceptance) are included
Screenshots before/after for front-end changes
Documentation (manuals or wiki) has been updated or is not required
Backports requested where applicable (ex: critical bugfixes)

+ switch($key) {
+ case 'ai.textprocessing_provider_preferences':
+ // fill $value with $defaultValue values
+ $value = array_merge($defaultValue, $value);


+ $value = array_merge($defaultValue, $value);
+ break;
+ case 'ai.translation_provider_preferences':
+ $value += array_diff($defaultValue, $value); // Add entries from $defaultValue that are not in $value to the end of $value


susnux · 2023-07-27T22:25:48Z

Nice! But keep in mind vuedragable is not accessible, so there is no way to reorder by using the keyboard, this needs to be done by the user of the component itself.

marcelklehr · 2023-07-28T09:48:21Z

@susnux How would you go about adding a11y here?

susnux · 2023-07-28T10:34:34Z

How would you go about adding a11y here?

For Forms I suggested this one: nextcloud/forms#1532

So basically either implement key event listeners (arrow up / down) or add additional buttons for ordering

marcelklehr · 2023-07-28T10:58:42Z

marcelklehr · 2023-07-28T10:59:22Z

/compile

julien-nc

Awesome, tested with a FreePrompt, a Summarize and an Outline TP provider.
The fallback works just fine if a provider fails.

Small string changes requested but all the rest LGTM.

I'm also wondering if all the unrelated stuff belongs here but since these are nice fixes, why not letting them in this.

About accessibility, there could be 2 buttons to move items up and down.

marcelklehr · 2023-07-28T14:08:12Z

About accessibility, there could be 2 buttons to move items up and down.

Already added :) (see screenshot above)

julien-nc · 2023-08-01T10:11:21Z

/compile

julien-nc · 2023-08-01T10:11:48Z

@Pytal Thanks for the review. Your changes have been implemented.
Rebased on master.

Signed-off-by: Marcel Klehr <mklehr@gmx.net>

…r precedence Signed-off-by: Marcel Klehr <mklehr@gmx.net>

Signed-off-by: Marcel Klehr <mklehr@gmx.net>

Co-authored-by: Julien Veyssier <julien-nc@posteo.net> Signed-off-by: Marcel Klehr <mklehr@gmx.net>

Signed-off-by: Marcel Klehr <mklehr@gmx.net>

Signed-off-by: Julien Veyssier <julien-nc@posteo.net>

julien-nc · 2023-08-02T12:54:55Z

Cypress failure is related with user settings.
acceptance-app-files failure is related with a file action menu button.

kesselb · 2023-08-02T22:23:12Z

The failing TextProcessingTest looks related:

kesselb · 2023-08-02T22:52:37Z

Fix: #39684

marcelklehr requested a review from julien-nc July 25, 2023 12:25

marcelklehr requested review from JuliaKirschenheuter and Pytal as code owners July 25, 2023 12:25

github-advanced-securityAI found potential problems Jul 25, 2023
View reviewed changes

szaimen added this to the Nextcloud 28 milestone Jul 27, 2023

szaimen added the 3. to review Waiting for reviews label Jul 27, 2023

github-advanced-securityAI found potential problems Jul 28, 2023
View reviewed changes

Comment threadcore/Migrations/Version28000Date20230728104802.php Fixed
Comment threadcore/Migrations/Version28000Date20230728104802.php Fixed

marcelklehr mentioned this pull request Jul 28, 2023
Summarize email thread nextcloud/mail#8508
Closed
5 tasks

marcelklehr force-pushed the enh/ai-admin-settings branch from 8cf0663 to 841a2fbCompare July 28, 2023 09:45

marcelklehr modified the milestones: Nextcloud 28, Nextcloud 27.1.0 Jul 28, 2023

julien-nc requested changes Jul 28, 2023
View reviewed changes

Comment threadapps/settings/lib/Settings/Admin/ArtificialIntelligence.php Outdated
Comment threadapps/settings/src/components/AdminAI.vue Outdated
Comment threadapps/settings/src/components/AdminAI.vue Outdated
Comment threadapps/settings/src/components/PersonalInfo/AvatarSection.vue

marcelklehr force-pushed the enh/ai-admin-settings branch from 0d71d57 to dd6e92fCompare July 28, 2023 15:40

Pytal reviewed Jul 31, 2023
View reviewed changes

Comment threadapps/settings/src/components/AdminAI.vue Outdated
Comment threadapps/settings/src/components/PersonalInfo/AvatarSection.vue
Comment threadcore/Migrations/Version28000Date20230728104802.php Outdated

julien-nc mentioned this pull request Aug 1, 2023
Integrate text processing API nextcloud/text#4613
Closed

julien-nc force-pushed the enh/ai-admin-settings branch from 81d3c4d to d2e75afCompare August 1, 2023 10:09

julien-nc self-requested a review August 1, 2023 10:09

julien-nc approved these changes Aug 1, 2023
View reviewed changes

julien-nc requested a review from Pytal August 1, 2023 10:11

julien-nc force-pushed the enh/ai-admin-settings branch 3 times, most recently from 1537edf to 474de78Compare August 1, 2023 13:32

marcelklehrand others added 20 commits August 2, 2023 12:37

AI admin settings: Use config values in AI feature managers
2a3ef10
Signed-off-by: Marcel Klehr <mklehr@gmx.net>

AI admin settings: Add a draggable icon in UI for translation provide…
2d29413
…r precedence Signed-off-by: Marcel Klehr <mklehr@gmx.net>

AI admin settings: Update composer autoloaders
aa74d6f
Signed-off-by: Marcel Klehr <mklehr@gmx.net>

AI admin settings: strict_types
f72f3f7
Signed-off-by: Marcel Klehr <mklehr@gmx.net>

AI admin settings: cs:fix
4ec150c
Signed-off-by: Marcel Klehr <mklehr@gmx.net>

AI admin settings: lint:fix
112268a
Signed-off-by: Marcel Klehr <mklehr@gmx.net>

AI admin settings: lint:fix
a193458
Signed-off-by: Marcel Klehr <mklehr@gmx.net>

AI admin settings: lint:fix
be7487b
Signed-off-by: Marcel Klehr <mklehr@gmx.net>

Migration: Drop llm_tasks table and add textprocessing_tasks
ad3f353
Signed-off-by: Marcel Klehr <mklehr@gmx.net>

Fix typo
a0eaed0
Signed-off-by: Marcel Klehr <mklehr@gmx.net>

Update apps/settings/src/components/AdminAI.vue
3ca4428
Co-authored-by: Julien Veyssier <julien-nc@posteo.net> Signed-off-by: Marcel Klehr <mklehr@gmx.net>

Update apps/settings/src/components/AdminAI.vue
ff39466
Co-authored-by: Julien Veyssier <julien-nc@posteo.net> Signed-off-by: Marcel Klehr <mklehr@gmx.net>

Admin AI settings: Improve a11y of machine translation precendence
830692c
Signed-off-by: Marcel Klehr <mklehr@gmx.net>

Admin AI settings: Use ContainerInterface instead of IServerContainer
7adb2ce
Signed-off-by: Marcel Klehr <mklehr@gmx.net>

move long click handlers into methods
5776406
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>

use DB type constants
601679b
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>

polish AI admin settings UI
0ace67c
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>

fix wrong NcSelect event in AI admin settings
a877865
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>

fix composer autoload files
8d6a6e5
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>

compile assets
b13ca86
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>

julien-nc force-pushed the enh/ai-admin-settings branch from 5f262ca to b13ca86Compare August 2, 2023 10:40

julien-nc merged commit 114cad3 into masterAug 2, 2023

julien-nc deleted the enh/ai-admin-settings branch August 2, 2023 12:55

This was referenced Aug 4, 2023
[Bug]: Text processing API can only run one task, then throws duplicate key errors #39657
Closed
Backport plan: Textprocessing for 27.1 #39738
Closed
[stable27] AI admin settings #39773
Closed
[stable27] The almighty text processing PR #39776
Merged

Uh oh!

Uh oh!

Conversation

marcelklehr commented Jul 25, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

Uh oh!

Uh oh!

Check notice

Check notice

susnux commented Jul 27, 2023

Uh oh!

Uh oh!

Uh oh!

marcelklehr commented Jul 28, 2023

Uh oh!

susnux commented Jul 28, 2023

Uh oh!

marcelklehr commented Jul 28, 2023

Uh oh!

marcelklehr commented Jul 28, 2023

Uh oh!

julien-nc left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

marcelklehr commented Jul 28, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

julien-nc commented Aug 1, 2023

Uh oh!

julien-nc commented Aug 1, 2023

Uh oh!

julien-nc commented Aug 2, 2023

Uh oh!

kesselb commented Aug 2, 2023

Uh oh!

kesselb commented Aug 2, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

marcelklehr commented Jul 25, 2023•
edited
Loading