Skip to content

Calendar optimizations - #39568

Merged
icewind1991 merged 2 commits into
masterfrom
caldav-share-preload
Aug 14, 2023
Merged

Calendar optimizations#39568
icewind1991 merged 2 commits into
masterfrom
caldav-share-preload

Conversation

@icewind1991

@icewind1991icewind1991 commented Jul 25, 2023

Copy link
Copy Markdown
Member
  • preload shares for calendars when listing calendars
  • cache calendar objects when doing calendarQuery

These save N queries when listing calendars and when listing calendar objects respectively.

Comment threadapps/dav/lib/DAV/Sharing/Backend.php Fixed
Comment threadapps/dav/lib/CalDAV/CalDavBackend.php Fixed
Comment threadapps/dav/lib/DAV/Sharing/Backend.php Fixed
@icewind1991icewind1991 changed the title preload shares for calendars when listing calendarsCalendar optimizationsJul 26, 2023
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
icewind1991force-pushed the caldav-share-preload branch from 7c4861f to 7c02eedCompareJuly 26, 2023 12:36
@icewind1991icewind1991 added this to the Nextcloud 28 milestone Jul 26, 2023
@icewind1991
icewind1991 marked this pull request as ready for review July 26, 2023 17:21

@tcitworldtcitworld left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really nice.

@kesselbkesselb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good change 👍

@kesselbkesselb added the 3. to review Waiting for reviews label Aug 2, 2023
@icewind1991
icewind1991 merged commit 30e9f52 into masterAug 14, 2023
@icewind1991
icewind1991 deleted the caldav-share-preload branch August 14, 2023 08:27
@icewind1991

Copy link
Copy Markdown
MemberAuthor

/backport to stable27

@icewind1991

Copy link
Copy Markdown
MemberAuthor

/backport to stable26

@backportbot-nextcloud

Copy link
Copy Markdown

The backport to stable26 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable26
git pull origin stable26
# Create the new backport branch
git checkout -b fix/foo-stable26
# Cherry pick the change from the commit sha1 of the change against the default branch# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable26

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@icewind1991

Copy link
Copy Markdown
MemberAuthor

26: #39861

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsperformance 🚀

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@icewind1991@tcitworld@kesselb@github-advanced-security@skjnldsv