Uh oh!
There was an error while loading. Please reload this page.
feat(accounts): implement birthday prop - #39592
Conversation
Signed-off-by: Simon L <szaimen@e.mail.de>
Uh oh!
There was an error while loading. Please reload this page.
| this.debouncePropertyChange(this.birthdayValue.toString()) | ||
| }, | ||
| debouncePropertyChange: debounce(async function(value) { |
There was a problem hiding this comment.
todo: should not duplicate the debounce logic
Signed-off-by: Simon L <szaimen@e.mail.de>
| $this->setupSystemCalendarProvider($cm); | ||
| } | ||
| public function setupSystemCalendarProvider(IManager $cm) { |
Check notice
Code scanning / Psalm
MissingReturnType
szaimen
commented
Jul 27, 2023
Unfortunately Richard and me did not succeed in publishing the birthday calendar to the calendar app yet. There are two ways how this could be accomplished in theory that we thought about:
|
tcitworld
commented
Jul 28, 2023
Another (more complex) possibility is to have something like nextcloud/calendar#4453. You would manually pick addressbooks you want to consider for the birthday calendar, including the system one. |
st3iny
commented
Jul 28, 2023
Yeah, well that would be a great extension. The complexity of the second option is already high enough for my liking. We will try to have another look at the feature if time permits. |
szaimen
commented
Jun 3, 2024
I guess this can be closed now that #45512 was merged? |
st3iny
commented
Jun 3, 2024
True. Your and Thomas' comment from earlier are worthy of archiving if anyone ever picks up the birthday calendar feature again. |
aurisnoctis
commented
Aug 21, 2024
Does this mean that #45512 does not cover integrating the birthdays into a calendar that everyone can see / subscribe to? |
st3iny
commented
Aug 22, 2024
Yes, there is currently no system-wide birthday calendar for users. This is very hard to implement correctly and the reasons are stated above. |
Summary
cc @szaimen@JohannesGGE
TODO
Checklist