Skip to content

feat: File reminders backend - #39651

Merged
Pytal merged 38 commits into
masterfrom
feat/files-reminders
Aug 3, 2023
Merged

feat: File reminders backend#39651
Pytal merged 38 commits into
masterfrom
feat/files-reminders

Conversation

@Pytal

@PytalPytal commented Aug 1, 2023•
edited
Loading

Copy link
Copy Markdown
Member

Summary

  • HTTP API
  • Notifier
  • Scheduled notifications
  • Clean up job

Checklist

@PytalPytal added this to the Nextcloud 27.1.0 milestone Aug 1, 2023
@PytalPytal self-assigned this Aug 1, 2023
come-nc
come-nc reviewed Aug 1, 2023
View reviewed changes
Comment threadapps/files_reminders/lib/Command/ListCommand.php Outdated
Comment threadapps/files_reminders/lib/Migration/Version10000Date20230725162149.php
Comment threadapps/files_reminders/lib/Notification/Notifier.php Outdated
@Pytal
Pytalforce-pushed the feat/files-reminders branch 2 times, most recently from d4d2332 to eeef52bCompareAugust 1, 2023 22:42
@PytalPytal mentioned this pull request Aug 3, 2023
Merged
10 tasks
come-nc
come-nc approved these changes Aug 3, 2023
View reviewed changes

@come-nccome-nc left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess another listener for if the user is deleted is needed as well, good otherwise.

susnux
susnux approved these changes Aug 3, 2023
View reviewed changes

@susnuxsusnux left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment threadapps/files_reminders/lib/Listener/NodeDeletedListener.php
Pytal added 13 commits August 3, 2023 15:30
@Pytal
feat: init files_reminders migration
e16001b
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
feat(files_reminders): add Application
59a2ef4
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
feat(files_reminders): add info xml
b75fac3
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
feat(files_reminders): add background jobs
a3ac1b8
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
feat(files_reminders): add service and notifier
ea5e128
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
feat(files_reminders): add list command
c8a32a7
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
enh: use datetime
163b059
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
enh: add created at
4fabd77
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
enh: implement JsonSerializable
774e3e6
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
feat(files_reminders): add api controller
a7892fb
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
fix: add composer autoload
cfbac9b
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
enh: add to shipped
beb8a27
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
enh: rename to due date
fa77564
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Pytal added 19 commits August 3, 2023 15:30
@Pytal
enh: return created status code
bdf0741
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
enh: comment interval
b04d1a7
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
enh: serialize path
db7f5a2
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
enh: does not exist return null
9bd7ddd
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
fix: return ocs data
3ade06c
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
fix: remove throwable handling
7daf11f
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
fix: construct background jobs
7617519
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
enh: handle node deleted
f865c3a
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
fix: exit on reminder not found
9e8354e
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
fix: catch NodeNotFoundException in notifier
c4b7056
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
enh: highlight filename
7beef65
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
fix: remove unnecessary parsed subject
7381c80
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
fix: return null if table exists
d619166
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
enh: add codeowner
113d061
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
enh: add json output to command
e320166
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
fix: ignore non-existing
2c4b562
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
fix(ci): add to enabled apps
af98c70
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
fix: set endpoint description
5a11535
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
enh: handle user deleted
a806bd0
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
Pytalforce-pushed the feat/files-reminders branch from 2734f38 to a806bd0CompareAugust 3, 2023 22:59
@PytalPytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Aug 3, 2023
@Pytal
Pytal merged commit 777f8c9 into masterAug 3, 2023
@Pytal
Pytal deleted the feat/files-reminders branch August 3, 2023 23:38
@PytalPytal mentioned this pull request Aug 3, 2023
Closed
3 tasks
@Pytal

Pytal commented Aug 8, 2023

Copy link
Copy Markdown
MemberAuthor

/backport to stable27

@backportbot-nextcloudbackportbot-nextcloudBot mentioned this pull request Aug 8, 2023
Merged
@nickvergessennickvergessen mentioned this pull request Aug 18, 2023
Merged
4 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@susnuxsusnuxsusnux approved these changes
@come-nccome-nccome-nc approved these changes
@ArtificialOwlArtificialOwlAwaiting requested review from ArtificialOwl
@icewind1991icewind1991Awaiting requested review from icewind1991
@skjnldsvskjnldsvAwaiting requested review from skjnldsvskjnldsv is a code owner

Assignees

@PytalPytal

Labels

4. to releaseReady to be released and/or waiting for tests to finishenhancementfeature: files

Projects

None yet

Milestone

Nextcloud 28

Development

Successfully merging this pull request may close these issues.

3 participants

@Pytal@susnux@come-nc