Uh oh!
There was an error while loading. Please reload this page.
[stable25] fix share roots always being marked as writable - #39671
Merged
Conversation
Uh oh!
There was an error while loading. Please reload this page.
ArtificialOwl
approved these changes
Aug 2, 2023
nickvergessen
requested changes
Aug 2, 2023
nickvergessen
left a comment
Member
There was a problem hiding this comment.
Didn't check the test file, but you can execute the test locally before pushing
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Merged
Signed-off-by: Robin Appelman <robin@icewind.nl>
nickvergessenforce-pushed
the
manual/backport/39614
branch
from
August 2, 2023 19:39
33f0559 to
ee29ab1Comparenickvergessen
approved these changes
Aug 2, 2023
nickvergessen
left a comment
Member
There was a problem hiding this comment.
Cherry-picked the original command from icewind and adjusted the : void in the test file which was the conflict.
AndyScherzinger
approved these changes
Aug 2, 2023
blizzz
approved these changes
Aug 2, 2023
nfebe
enabled auto-merge
August 2, 2023 23:37
nfebe
disabled auto-merge
August 3, 2023 07:16
nfebe
commented
Aug 3, 2023
ContributorAuthor
CI, fail is erratic and unrelated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #39614