Skip to content

Refactor encryption app commands - #39692

Merged
skjnldsv merged 2 commits into
nextcloud:masterfrom
fsamapoor:refactor_encryption_app_commands
Aug 16, 2024
Merged

Refactor encryption app commands#39692
skjnldsv merged 2 commits into
nextcloud:masterfrom
fsamapoor:refactor_encryption_app_commands

Conversation

@fsamapoor

@fsamapoorfsamapoor commented Aug 3, 2023•
edited
Loading

Copy link
Copy Markdown
Member

Summary

I have made some adjustments to the apps/encryption/lib/Command classes to improve the code readability.

The improvements in this PR include but are not limited to:

  • Using PHP8's constructor property promotion
  • Adding return types
  • Replacing return code integers with more readable strings.
  • Using early returns

Checklist

@fsamapoor
fsamapoorforce-pushed the refactor_encryption_app_commands branch from 1553fcb to 4507123CompareAugust 3, 2023 11:31
github-advanced-security[bot]
github-advanced-securityAI found potential problems Aug 3, 2023
View reviewed changes
Comment threadapps/encryption/lib/Command/FixEncryptedVersion.php Fixed
@fsamapoor
fsamapoor requested review from a team, ArtificialOwl, icewind1991 and nfebe and removed request for a teamAugust 5, 2023 20:25
@fsamapoorfsamapoor added 3. to review Waiting for reviews technical debt 🧱 🤔🚀 labels Aug 5, 2023
@fsamapoor
fsamapoorforce-pushed the refactor_encryption_app_commands branch from 4507123 to 1b009e2CompareAugust 10, 2023 11:52
@fsamapoor

fsamapoor commented Aug 10, 2023

Copy link
Copy Markdown
MemberAuthor

Conflicts resolved.

@fsamapoorfsamapoor added this to the Nextcloud 28 milestone Aug 10, 2023
nfebe
nfebe approved these changes Aug 14, 2023
View reviewed changes

@nfebenfebe left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, rebase this against latest master.

@fsamapoor
fsamapoorforce-pushed the refactor_encryption_app_commands branch from 1b009e2 to 881123fCompareAugust 14, 2023 08:51
@fsamapoor

fsamapoor commented Aug 14, 2023

Copy link
Copy Markdown
MemberAuthor

Please, rebase this against latest master.

Done. But it has already got out-of-dated. Should I rebase it again?
I think we can wait for the second review for now.

@nfebe

nfebe commented Aug 14, 2023

Copy link
Copy Markdown
Contributor

@fsamapoor thanks, all good! I was hoping CI might get green if you rebase but no, it's fine. Just wait for other reviews.

@fsamapoor
fsamapoorforce-pushed the refactor_encryption_app_commands branch from 881123f to ab2caedCompareAugust 15, 2023 06:17
@fsamapoor

fsamapoor commented Aug 17, 2023

Copy link
Copy Markdown
MemberAuthor

@fenn-cs Cypress workflows are failing on almost all of my PRs. I don't know if there is anything that I can do to fix them.

@nfebe

nfebe commented Aug 17, 2023

Copy link
Copy Markdown
Contributor

@fsamapoor Not to worry, those failures are unrelated (most likely as they are UI tests).

@fsamapoor
fsamapoorforce-pushed the refactor_encryption_app_commands branch from ab2caed to 37bf803CompareSeptember 9, 2023 06:41
@fsamapoor

fsamapoor commented Sep 9, 2023

Copy link
Copy Markdown
MemberAuthor

Conflicts resolved.

@nfebe

nfebe commented Sep 12, 2023

Copy link
Copy Markdown
Contributor

Conflicts resolved.

Thank you, please rebase.

@fsamapoor
fsamapoorforce-pushed the refactor_encryption_app_commands branch from 37bf803 to a45dd55CompareSeptember 12, 2023 11:57
@fsamapoor

fsamapoor commented Sep 12, 2023

Copy link
Copy Markdown
MemberAuthor

Thank you, please rebase.

Done.

@nfebe

nfebe commented Sep 18, 2023

Copy link
Copy Markdown
Contributor

@fsamapoor now that this has another approval kindly, update/rebase it with master I would put my eyes on the jobs to get it in asap.

Thank you!

@fsamapoor
fsamapoorforce-pushed the refactor_encryption_app_commands branch from a45dd55 to 68da42aCompareSeptember 18, 2023 19:10
@fsamapoor

fsamapoor commented Sep 18, 2023

Copy link
Copy Markdown
MemberAuthor

@fsamapoor now that this has another approval kindly, update/rebase it with master I would put my eyes on the jobs to get it in asap.

Thank you!

Sure. Thank you! Other than Cypress workflows, I think there will be no issues.

@skjnldsvskjnldsv mentioned this pull request Nov 1, 2023
Merged
This was referenced Mar 18, 2024
Merged
Merged
Merged
@skjnldsvskjnldsv mentioned this pull request Mar 28, 2024
Merged
81 tasks
This was referenced Apr 4, 2024
Merged
Merged
@blizzzblizzz modified the milestones: Nextcloud 29, Nextcloud 30Apr 8, 2024
@skjnldsvskjnldsv added 2. developing Work in progress stale Ticket or PR with no recent activity and removed 3. to review Waiting for reviews labels Jul 27, 2024
This was referenced Jul 30, 2024
Merged
Merged
This was referenced Aug 5, 2024
Merged
Merged
@skjnldsvskjnldsv mentioned this pull request Aug 13, 2024
Merged
@skjnldsvskjnldsv removed this from the Nextcloud 30 milestone Aug 14, 2024
@skjnldsvskjnldsv reopened this Aug 16, 2024
Faraz Samapoor added 2 commits August 16, 2024 09:33
Faraz Samapoor@skjnldsv
Refactors encryption app commands.
fc8b886
To improve code readability.
Signed-off-by: Faraz Samapoor <fsa@adlas.at>
Faraz Samapoor@skjnldsv
Uses early returns.
6b795da
To improve code readability.
Signed-off-by: Faraz Samapoor <fsa@adlas.at>
@skjnldsv
skjnldsvforce-pushed the refactor_encryption_app_commands branch from 7899057 to 6b795daCompareAugust 16, 2024 07:33
@skjnldsvskjnldsv self-assigned this Aug 16, 2024
@skjnldsvskjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 2. developing Work in progress stale Ticket or PR with no recent activity labels Aug 16, 2024
@skjnldsv
skjnldsv merged commit 75180a6 into nextcloud:masterAug 16, 2024
@skjnldsvskjnldsv added this to the Nextcloud 31 milestone Aug 16, 2024
@fsamapoor
fsamapoor deleted the refactor_encryption_app_commands branch August 19, 2024 07:00
@skjnldsvskjnldsv mentioned this pull request Jan 7, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@icewind1991icewind1991icewind1991 approved these changes
@nfebenfebenfebe approved these changes
@ArtificialOwlArtificialOwlAwaiting requested review from ArtificialOwlArtificialOwl is a code owner automatically assigned from nextcloud/server-backend

Assignees

@skjnldsvskjnldsv

Labels

4. to releaseReady to be released and/or waiting for tests to finishtechnical debt🧱 🤔🚀

Projects

None yet

Milestone

Nextcloud 31

Development

Successfully merging this pull request may close these issues.

6 participants

@fsamapoor@nfebe@icewind1991@github-advanced-security@blizzz@skjnldsv