Uh oh!
There was an error while loading. Please reload this page.
always normalize unicode strings - #39730
Closed
haikyuu wants to merge 1 commit into
Closed
Conversation
8 tasks
Merged
AndyScherzinger
requested review from
sorbaugh
and removed request for
PVince81February 27, 2024 13:28
Signed-off-by: abdellah <als.abdellah@gmail.com>
AndyScherzingerforce-pushed
the
fix/normalization
branch
from
February 27, 2024 13:28
9b793a2 to
bdf2672Compare
This was referenced Mar 12, 2024
Merged
Merged
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This always normalizes strings instead of checking first.
TODO
Checklist