Skip to content

feat(caldav): linkify location in scheduling mails - #39753

Merged
ChristophWurst merged 1 commit into
masterfrom
feat/caldav/linkify-location-in-email
Aug 9, 2023
Merged

feat(caldav): linkify location in scheduling mails#39753
ChristophWurst merged 1 commit into
masterfrom
feat/caldav/linkify-location-in-email

Conversation

@st3iny

Copy link
Copy Markdown
Member

Summary

Invitation

grafik

Event is updated

grafik

TODO

  • Probably tests

Checklist

@st3inyst3iny added enhancement 2. developing Work in progress feature: caldav Related to CalDAV internals labels Aug 8, 2023
@st3inyst3iny self-assigned this Aug 8, 2023
@st3iny

Copy link
Copy Markdown
MemberAuthor

I tried to inject evil code into the location field but it was sanitized properly. The general email html sanitization seems to take care of this.

Comment threadapps/dav/lib/CalDAV/Schedule/IMipService.php Outdated
@st3iny
st3inyforce-pushed the feat/caldav/linkify-location-in-email branch from 58f0657 to 5671393CompareAugust 8, 2023 14:17
@st3inyst3iny added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Aug 8, 2023
@st3iny
st3iny marked this pull request as ready for review August 8, 2023 14:18
Comment threadapps/dav/lib/CalDAV/Schedule/IMipService.php Outdated
@ChristophWurst

Copy link
Copy Markdown
Member

/backport to stable27

@ChristophWurstChristophWurst left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Comment threadapps/dav/lib/CalDAV/Schedule/IMipService.php Fixed
@st3inyst3iny added this to the Nextcloud 28 milestone Aug 9, 2023
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
@st3iny
st3inyforce-pushed the feat/caldav/linkify-location-in-email branch from ed64f30 to 2ac24d5CompareAugust 9, 2023 08:50
@st3inyst3iny added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Aug 9, 2023
@ChristophWurst
ChristophWurst merged commit df304bd into masterAug 9, 2023
@ChristophWurst
ChristophWurst deleted the feat/caldav/linkify-location-in-email branch August 9, 2023 16:11
@ChristophWurst

Copy link
Copy Markdown
Member

/backport to stable27

@ChristophWurst

Copy link
Copy Markdown
Member

/backport to stable27

@backportbot-nextcloud

Copy link
Copy Markdown

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin stable27
# Create the new backport branch
git checkout -b fix/foo-stable27
# Cherry pick the change from the commit sha1 of the change against the default branch# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

1 similar comment
@backportbot-nextcloud

Copy link
Copy Markdown

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin stable27
# Create the new backport branch
git checkout -b fix/foo-stable27
# Cherry pick the change from the commit sha1 of the change against the default branch# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@ChristophWurst

Copy link
Copy Markdown
Member

/backport to stable27

@backportbot-nextcloud

Copy link
Copy Markdown

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin stable27
# Create the new backport branch
git checkout -b fix/foo-stable27
# Cherry pick the change from the commit sha1 of the change against the default branch# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

1 similar comment
@backportbot-nextcloud

Copy link
Copy Markdown

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin stable27
# Create the new backport branch
git checkout -b fix/foo-stable27
# Cherry pick the change from the commit sha1 of the change against the default branch# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@ChristophWurst

Copy link
Copy Markdown
Member

/backport to stable27

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to releaseReady to be released and/or waiting for tests to finishenhancementfeature: caldavRelated to CalDAV internals

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Improve handling of links for online events

4 participants

@st3iny@ChristophWurst@tcitworld@github-advanced-security