Uh oh!
There was an error while loading. Please reload this page.
log imaginary errors as info to not spam the server logs - #39780
Merged
Conversation
Signed-off-by: Simon L <szaimen@e.mail.de>
szaimen
commented
Aug 9, 2023
ContributorAuthor
/backport to stable27 |
AndyScherzinger
approved these changes
Aug 10, 2023
tcitworld
approved these changes
Aug 10, 2023
szaimen
commented
Aug 10, 2023
ContributorAuthor
CI failure unrelated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason: usually if preview generation fails, the admin cannot do much about it. In order to not spam the error logs, move the logs to info mode. Additional logs are shown in the imaginary container anyway, so should still be pretty easy to debug.