Uh oh!
There was an error while loading. Please reload this page.
feat: Add new Vue FilePicker from @nextcloud/dialogs and use it by default - #39792
Conversation
82ce32b to
d362b03CompareUh oh!
There was an error while loading. Please reload this page.
d362b03 to
a219d13CompareAndyScherzinger
commented
Aug 10, 2023
but files will use the new one right-away? |
a219d13 to
79b31b8Comparesusnux
commented
Aug 10, 2023
Correct by default the new one is used everywhere. |
6114a63 to
a66f9bfCompare
jancborchardt
left a comment
There was a problem hiding this comment.
Nice! :) Only 2 additional things besides @szaimen’s points:
- The loading skeleton screen elements are too dark on the background. We had a similar issue in Mail or elsewhere, I thought it was fixed in the components?
- The "Modified" column should be left-aligned like it is now in files. Only "Size" is right-aligned as it has numbers which can extend to the left, but modified is numbers + text.
Thank you for your feedback :)
I think this is an issue with the nextcloud vue library as this is from the NcBreadcrumbs component.
Currently there is always checkboxes shown (if multiselect is enabled then there is also a select all one in the table header).
You are right, on darkmode I did not noticed it that much but I agree we should make them lighter.
Thank you, will change this :) |
szaimen
commented
Aug 10, 2023
Thanks @susnux! :)
I see, I can create an issue for this if you want :)
Yes, I think so :) Please dont forget my third point :)
|
a66f9bf to
a92bb9cCompare
Yes 😅 |
Rebasing... done! |
3d6deeb to
fc3ec11Compare
This comment was marked as resolved.
This comment was marked as resolved.
fc3ec11 to
cc4e20dCompareskjnldsv
commented
Aug 24, 2023
If the cypress user test fails with |
skjnldsv
commented
Aug 24, 2023
Added a theming fix. |
619c846 to
9c6273bCompare…fault. Still providing the legacy one until the Vue FilePicker is out of beta. Pin beta releases so we do not get version conflicts. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
8f0f0e5 to
5831d4fCompareSigned-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
commented
Aug 26, 2023
should be ready to go? |
skjnldsv
commented
Aug 27, 2023
Congrats!! 🎉 🎉 🎉 |


Summary
(Still providing the legacy one until the Vue FilePicker is out of beta.)
Basically just use the new component from the dialogs package, see information in the PR nextcloud-libraries/nextcloud-dialogs#878
Screenshots
vokoscreenNG-2023-08-10_04-21-53.mp4
And on smaller screens:

TODO
Checklist