Uh oh!
There was an error while loading. Please reload this page.
move share permission logic to storage wrapper - #39863
Merged
Merged
Conversation
icewind1991
requested review from
a team, ArtificialOwl, blizzz and nfebe
and removed request for
a teamAugust 14, 2023 13:51
icewind1991force-pushed
the
sharing-mask-wrapper
branch
2 times, most recently
from
August 14, 2023 14:33
3f5d00c to
a3e6dd2Comparethis way we only have to determine the share permissions once Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991force-pushed
the
sharing-mask-wrapper
branch
2 times, most recently
from
August 15, 2023 16:27
1701426 to
79dab07Compareicewind1991force-pushed
the
sharing-mask-wrapper
branch
2 times, most recently
from
August 15, 2023 18:25
b3026cd to
f15f58cCompareicewind1991force-pushed
the
sharing-mask-wrapper
branch
2 times, most recently
from
August 16, 2023 09:01
2f49e8c to
1ce6452CompareSigned-off-by: Robin Appelman <robin@icewind.nl>
icewind1991force-pushed
the
sharing-mask-wrapper
branch
from
August 16, 2023 13:25
1ce6452 to
e73889aCompareAndyScherzinger
approved these changes
Aug 18, 2023
AndyScherzinger
approved these changes
Sep 4, 2023
come-nc
approved these changes
Sep 4, 2023
This was referenced Sep 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this way we only have to determine the share permissions once per storage instead of once per file
Saves about 30% time in large file listings: https://blackfire.io/profiles/compare/e6ab53a7-9b04-415b-ba07-1dd069fb19a1/graph