Skip to content

adjust add button - #39884

Merged
szaimen merged 2 commits into
masterfrom
enh/37207/adjust-add-button
Aug 16, 2023
Merged

adjust add button#39884
szaimen merged 2 commits into
masterfrom
enh/37207/adjust-add-button

Conversation

@szaimen

@szaimenszaimen commented Aug 15, 2023

Copy link
Copy Markdown
Contributor

Close#37207

BeforeAfter
imageimage

@szaimenszaimen added this to the Nextcloud 28 milestone Aug 15, 2023
@szaimen

Copy link
Copy Markdown
ContributorAuthor

/backport to stable27

@szaimen

Copy link
Copy Markdown
ContributorAuthor

/compile amend /

@szaimen
szaimen marked this pull request as ready for review August 15, 2023 14:30
@szaimenszaimen added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Aug 15, 2023
@szaimen
szaimen requested review from a team, AndyScherzinger, Pytal, artonge and susnux and removed request for a teamAugust 15, 2023 14:30
Signed-off-by: Simon L <szaimen@e.mail.de>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@nextcloud-command
nextcloud-commandforce-pushed the enh/37207/adjust-add-button branch from 2cbce95 to cec4986CompareAugust 15, 2023 14:38
@susnux

Copy link
Copy Markdown
Contributor

Can we make the button look like a NcButton with primary styling? So increase the gap between icon and text and remove the border. As with a NcButton it looks like this:

image

@szaimen

szaimen commented Aug 15, 2023

Copy link
Copy Markdown
ContributorAuthor

How many pixel should the gap be?

@susnux

susnux commented Aug 15, 2023

Copy link
Copy Markdown
Contributor

How many pixel should the gap be?

For vue buttons it seems there is no gap but the icon is 44px by 44px.
Maybe assign to .button.new .icon:

width:44px;
background-size:20px20px;

and to the button (.button.new):

padding:016px04px;

This should emulate the vue button styling.

@szaimen
szaimenforce-pushed the enh/37207/adjust-add-button branch from d3a53cf to 7d51257CompareAugust 16, 2023 10:51
@szaimen

Copy link
Copy Markdown
ContributorAuthor

/compile amend /

@szaimen
szaimen requested review from susnux and removed request for susnuxAugust 16, 2023 10:52
Signed-off-by: Simon L <szaimen@e.mail.de>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@nextcloud-command
nextcloud-commandforce-pushed the enh/37207/adjust-add-button branch from 7d51257 to 7926b63CompareAugust 16, 2023 11:20
@szaimen
szaimen enabled auto-merge August 16, 2023 11:29

@jancborchardtjancborchardt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very nice! :)

@szaimen
szaimen merged commit 12805ee into masterAug 16, 2023
@szaimen
szaimen deleted the enh/37207/adjust-add-button branch August 16, 2023 15:11
@backportbot-nextcloud

Copy link
Copy Markdown

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin stable27
# Create the new backport branch
git checkout -b fix/foo-stable27
# Cherry pick the change from the commit sha1 of the change against the default branch# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@szaimen

Copy link
Copy Markdown
ContributorAuthor

/backport to stable27

@backportbot-nextcloud

Copy link
Copy Markdown

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin stable27
# Create the new backport branch
git checkout -b fix/foo-stable27
# Cherry pick the change from the commit sha1 of the change against the default branch# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@szaimen
szaimen restored the enh/37207/adjust-add-button branch August 16, 2023 15:42
@szaimenszaimen mentioned this pull request Aug 16, 2023
@szaimen
szaimen deleted the enh/37207/adjust-add-button branch August 16, 2023 15:46
@szaimen

Copy link
Copy Markdown
ContributorAuthor

#39915

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsenhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upload/add button style and discoverability

4 participants

@szaimen@susnux@jancborchardt@AndyScherzinger