Uh oh!
There was an error while loading. Please reload this page.
Reduce the number of container queries - #39888
Merged
Merged
Conversation
icewind1991
requested review from
a team, ArtificialOwl, blizzz, nfebe and nickvergessen
and removed request for
a teamAugust 15, 2023 16:38
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
icewind1991force-pushed
the
less-container-queries
branch
2 times, most recently
from
August 15, 2023 18:27
d34d475 to
1906e39Compareicewind1991force-pushed
the
less-container-queries
branch
from
August 18, 2023 07:35
1906e39 to
0c0e7d4CompareAndyScherzinger
approved these changes
Aug 18, 2023
Altahrim
approved these changes
Aug 18, 2023
icewind1991
commented
Aug 18, 2023
MemberAuthor
acceptance failures might be related, will look into it later |
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991force-pushed
the
less-container-queries
branch
from
August 18, 2023 09:15
0c0e7d4 to
55fa391CompareUh oh!
There was an error while loading. Please reload this page.
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991force-pushed
the
less-container-queries
branch
from
August 18, 2023 12:25
55fa391 to
b6c3507Comparenickvergessen
approved these changes
Aug 18, 2023
nickvergessen
enabled auto-merge
August 18, 2023 13:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tweaks DI in various places to prevent calling
Server::getin a loop.While the container is fairly fast, doing a lot of queries adds up.