Skip to content

improve di performance for cache - #39889

Merged
skjnldsv merged 3 commits into
masterfrom
cache-di
Feb 13, 2024
Merged

improve di performance for cache#39889
skjnldsv merged 3 commits into
masterfrom
cache-di

Conversation

@icewind1991

@icewind1991icewind1991 commented Aug 15, 2023

Copy link
Copy Markdown
Member

not really the cleanest, but Cache is to deeply integrated to add a ton of DI parameters without being a major pain

@icewind1991icewind1991 added this to the Nextcloud 28 milestone Aug 15, 2023
@icewind1991
icewind1991force-pushed the cache-di branch 2 times, most recently from 913ed51 to 4ce0831CompareAugust 16, 2023 09:04
@icewind1991icewind1991 mentioned this pull request Aug 16, 2023
Closed
@icewind1991
icewind1991force-pushed the cache-di branch 2 times, most recently from 39136b1 to 94bdd21CompareAugust 16, 2023 14:22
@icewind1991
icewind1991force-pushed the cache-di branch 3 times, most recently from 5c653ad to 72ee145CompareAugust 28, 2023 12:21
@skjnldsvskjnldsv mentioned this pull request Nov 1, 2023
Merged
This was referenced Nov 6, 2023
Merged
Merged
This was referenced Nov 14, 2023
Merged
Merged
@blizzzblizzz modified the milestones: Nextcloud 28, Nextcloud 29Nov 23, 2023
@icewind1991
improve di performance for cache
7a91abb
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
icewind1991force-pushed the cache-di branch 2 times, most recently from 2de315a to 677a4c9CompareFebruary 9, 2024 12:43
github-advanced-security[bot]
github-advanced-securityAI found potential problems Feb 9, 2024
View reviewed changes
Comment threadlib/private/Files/Cache/Wrapper/CacheWrapper.php Fixed
Comment threadlib/private/Files/Cache/Wrapper/CacheWrapper.php Fixed
@icewind1991
also improe cache ci for shared cache
e50c176
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
icewind1991 requested review from a team, Altahrim, ArtificialOwl and nfebe and removed request for a teamFebruary 9, 2024 14:03
skjnldsv
skjnldsv reviewed Feb 10, 2024
View reviewed changes
Comment threadapps/files_external/tests/Service/StoragesServiceTest.php
skjnldsv
skjnldsv reviewed Feb 10, 2024
View reviewed changes
Comment threadapps/files_external/tests/Service/StoragesServiceTest.php Outdated
skjnldsv
skjnldsv reviewed Feb 10, 2024
View reviewed changes
Comment threadlib/private/Files/Cache/Wrapper/CacheWrapper.php Outdated
skjnldsv
skjnldsv reviewed Feb 10, 2024
View reviewed changes
Comment threadlib/private/Files/Cache/Wrapper/CacheWrapper.php
skjnldsv
skjnldsv reviewed Feb 10, 2024
View reviewed changes
Comment threadlib/private/Files/Storage/Common.php Outdated
skjnldsv
skjnldsv requested changes Feb 10, 2024
View reviewed changes

@skjnldsvskjnldsv left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

@icewind1991
use OCP\Server
e9d97a5
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991

icewind1991 commented Feb 12, 2024

Copy link
Copy Markdown
MemberAuthor

See comments

fixed

@skjnldsv
skjnldsv merged commit 56640c7 into masterFeb 13, 2024
@skjnldsv
skjnldsv deleted the cache-di branch February 13, 2024 08:40
@blizzzblizzz mentioned this pull request Mar 5, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AndyScherzingerAndyScherzingerAndyScherzinger approved these changes
@skjnldsvskjnldsvskjnldsv approved these changes
@ArtificialOwlArtificialOwlAwaiting requested review from ArtificialOwlArtificialOwl is a code owner automatically assigned from nextcloud/server-backend
@AltahrimAltahrimAwaiting requested review from AltahrimAltahrim is a code owner automatically assigned from nextcloud/server-backend
@nfebenfebeAwaiting requested review from nfebenfebe is a code owner automatically assigned from nextcloud/server-backend

Assignees

No one assigned

Labels

3. to reviewWaiting for reviewsperformance 🚀

Projects

None yet

Milestone

Nextcloud 29

Development

Successfully merging this pull request may close these issues.

5 participants

@icewind1991@AndyScherzinger@skjnldsv@github-advanced-security@blizzz