Uh oh!
There was an error while loading. Please reload this page.
admin have no special rights on users' entries - #39895
Merged
Merged
Conversation
Uh oh!
There was an error while loading. Please reload this page.
ArtificialOwlforce-pushed
the
fix/noid/revoke-admin-overwrite
branch
from
August 16, 2023 14:31
680b42e to
fb2d29eCompareArtificialOwl
commented
Aug 16, 2023
MemberAuthor
failed test are not related |
icewind1991
approved these changes
Aug 17, 2023
ArtificialOwlforce-pushed
the
fix/noid/revoke-admin-overwrite
branch
3 times, most recently
from
August 18, 2023 11:13
fd40401 to
40584f1Compare| // Non-admins can only edit their own credentials | ||
| $allowedToEdit = ($this->groupManager->isAdmin($currentUser->getUID()) || $currentUser->getUID() === $uid); | ||
| $allowedToEdit = ($currentUser->getUID() === $uid); |
Check notice
Code scanning / Psalm
PossiblyNullReference
ArtificialOwl
commented
Aug 18, 2023
MemberAuthor
/backport to stable27 |
ArtificialOwl
commented
Aug 18, 2023
MemberAuthor
/backport to stable26 |
AndyScherzinger
approved these changes
Aug 31, 2023
| public function testSaveGlobalCredentialsAsNormalUserForSelf() { | ||
| $user = $this->createMock(IUser::class); | ||
| $user | ||
| ->expects($this->exactly(2)) |
Member
There was a problem hiding this comment.
I'm in favor of just removing these count checks unless the number of times something is called is actually relevant to the test
MemberAuthor
There was a problem hiding this comment.
Thanks! and I thought I was the only one
ArtificialOwlforce-pushed
the
fix/noid/revoke-admin-overwrite
branch
3 times, most recently
from
August 31, 2023 20:27
2c1db9d to
6607388CompareArtificialOwl
enabled auto-merge
August 31, 2023 20:27
ArtificialOwl
disabled auto-merge
August 31, 2023 21:54
ArtificialOwlforce-pushed
the
fix/noid/revoke-admin-overwrite
branch
from
August 31, 2023 21:55
6607388 to
1275bdfCompareArtificialOwl
enabled auto-merge
August 31, 2023 21:55
ArtificialOwlforce-pushed
the
fix/noid/revoke-admin-overwrite
branch
from
September 1, 2023 09:23
1275bdf to
435f475CompareArtificialOwl
disabled auto-merge
September 1, 2023 10:19
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
skjnldsvforce-pushed
the
fix/noid/revoke-admin-overwrite
branch
from
September 1, 2023 18:14
435f475 to
e55087bCompareThe backport to stable26 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable26
git pull origin stable26
# Create the new backport branch
git checkout -b fix/foo-stable26
# Cherry pick the change from the commit sha1 of the change against the default branch# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable26More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
ArtificialOwl
commented
Sep 5, 2023
MemberAuthor
/backport to stable25 |
AndyScherzinger
commented
Sep 6, 2023
Member
/backport to stable26 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
remove admin's right to modify users' external filesystem configuration.