Skip to content

Improve upload progress visualization - #39912

Merged
susnux merged 3 commits into
masterfrom
fix/improved-upload-view
Aug 22, 2023
Merged

Improve upload progress visualization#39912
susnux merged 3 commits into
masterfrom
fix/improved-upload-view

Conversation

@susnux

Copy link
Copy Markdown
Contributor

Summary

Improving the upload progress bar's "Time remaining". Tested with a single large file and multiple smaller files.
Besides the existing moving average, a smoothing factor is introduced for the time remaining display as well as the bitrate.
Furthermore, half of the buffer needs to be filled before the first prediction is displayed to the user. This reduces volatile and jumping durations towards the user and improves usability.

I extended the origin PR as follows:

  • Fixed initial value of smooth* (check for undefined)
  • Only show the remaining time if the buffer is fully filled to prevent inconsistent forecasts
  • Show number of finished and total uploads, this is required if you upload many files. Otherwise you might not see any progress.

Checklist

@susnuxsusnux added 3. to review Waiting for reviews feature: files labels Aug 16, 2023
@susnux
susnux requested review from a team, Pytal, artonge and szaimen and removed request for a teamAugust 16, 2023 14:49
@susnux
susnuxforce-pushed the fix/improved-upload-view branch from 820164e to f491b63CompareAugust 16, 2023 14:56
@szaimenszaimen added this to the Nextcloud 28 milestone Aug 16, 2023
@susnux
susnuxforce-pushed the fix/improved-upload-view branch from f491b63 to 031f6e5CompareAugust 16, 2023 15:19

@szaimenszaimen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and seems to work in general, there might be some edge cases though that do not work perfect but that has possibly already been there before. Also didnt review the code

@susnux

Copy link
Copy Markdown
ContributorAuthor

/backport to stable27

@susnux

Copy link
Copy Markdown
ContributorAuthor

/backport to stable26

@susnux

Copy link
Copy Markdown
ContributorAuthor

/backport to stable25

@susnux
susnux requested a review from skjnldsvAugust 16, 2023 20:34
skjnldsv
skjnldsv previously requested changes Aug 17, 2023

@skjnldsvskjnldsv left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's wait for #39808 please

@susnux
susnux requested a review from skjnldsvAugust 19, 2023 13:14
@susnux
susnux dismissed skjnldsv’s stale reviewAugust 19, 2023 13:14

The PR is now merged, lets fix this so we can backport to stable27

@susnux
susnuxforce-pushed the fix/improved-upload-view branch from 031f6e5 to 1df60c0CompareAugust 19, 2023 14:07
@susnux
susnuxforce-pushed the fix/improved-upload-view branch from 1df60c0 to 15c4516CompareAugust 20, 2023 13:47
Phlogiand others added 3 commits August 21, 2023 23:18
Besides the existing moving average, a smoothing factor is introduced for the time remaining display as well as the bitrate.
Furthermore, half of the buffer needs to be filled before the first prediction is displayed to the user. This reduces volatile and jumping durations towards the user and improves usability.
Signed-off-by: Cyrill H. <phlogi@posteo.de>
Co-authored-by: Carl Schwan <carl@carlschwan.eu>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
susnuxforce-pushed the fix/improved-upload-view branch from 15c4516 to 39e0a42CompareAugust 21, 2023 21:18
@skjnldsv

Copy link
Copy Markdown
Member

Shall this be done for https://github.com/nextcloud-libraries/nextcloud-upload too?

@susnux

Copy link
Copy Markdown
ContributorAuthor

Shall this be done for https://github.com/nextcloud-libraries/nextcloud-upload too?

If it is relevant for the library then yes

@skjnldsv

Copy link
Copy Markdown
Member

If it is relevant for the library then yes

We're using a dedicated library that calculates remaining time and such 🤔 🤷

@susnux

Copy link
Copy Markdown
ContributorAuthor

Cypress seems unrelated

@susnux
susnux merged commit da3c941 into masterAug 22, 2023
@susnux
susnux deleted the fix/improved-upload-view branch August 22, 2023 11:03
@backportbot-nextcloud

Copy link
Copy Markdown

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin stable27
# Create the new backport branch
git checkout -b fix/foo-stable27
# Cherry pick the change from the commit sha1 of the change against the default branch# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@backportbot-nextcloud

Copy link
Copy Markdown

The backport to stable26 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable26
git pull origin stable26
# Create the new backport branch
git checkout -b fix/foo-stable26
# Cherry pick the change from the commit sha1 of the change against the default branch# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable26

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@backportbot-nextcloud

Copy link
Copy Markdown

The backport to stable25 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable25
git pull origin stable25
# Create the new backport branch
git checkout -b fix/foo-stable25
# Cherry pick the change from the commit sha1 of the change against the default branch# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable25

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsfeature: files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@susnux@skjnldsv@AndyScherzinger@szaimen@Phlogi