Uh oh!
There was an error while loading. Please reload this page.
[stable27] fix(files): Fix legacy files list sorting - #39919
Merged
Conversation
susnux
requested review from
a team, Pytal, artonge and skjnldsv
and removed request for
a teamAugust 16, 2023 18:14
susnux
commented
Aug 16, 2023
ContributorAuthor
/backport to stable27 |
susnuxforce-pushed
the
fix/legacy-files-list-sorting
branch
from
August 16, 2023 18:14
921fd9b to
a1699a3Comparesusnux
commented
Aug 16, 2023
ContributorAuthor
@skjnldsv after f2v this is not required on master, but we need this for stable27. |
susnuxforce-pushed
the
fix/legacy-files-list-sorting
branch
from
August 16, 2023 21:12
a1699a3 to
40dec98Compareskjnldsv
previously requested changes
Aug 17, 2023
skjnldsv
left a comment
Member
There was a problem hiding this comment.
Let's wait for #39808 please 🙏
That way you can also use the cypress selectors
https://github.com/nextcloud/server/blob/feat/f2v/files/cypress/e2e/files.cy.ts
susnux
commented
Aug 17, 2023
ContributorAuthor
susnuxforce-pushed
the
fix/legacy-files-list-sorting
branch
from
August 18, 2023 12:27
40dec98 to
e79509aComparesusnux
requested review from
ArtificialOwl, ChristophWurst, JuliaKirschenheuter, come-nc, icewind1991, julien-nc, miaulalala, nfebe, nickvergessen, provokateurin, st3iny and tcitworld
as code ownersAugust 18, 2023 12:27
susnux
requested review from
skjnldsv
and removed request for
ArtificialOwl, ChristophWurst, JuliaKirschenheuter, come-nc, icewind1991, julien-nc, miaulalala, nickvergessen, provokateurin, st3iny and tcitworldAugust 18, 2023 12:27
susnux
commented
Aug 18, 2023
ContributorAuthor
Changed the base to stable27, as this is no longer needed for master (thanks to f2v :) ). Sorry for the noise Github assigned everyone for a short moment... |
AndyScherzinger
approved these changes
Aug 18, 2023
artonge
approved these changes
Aug 18, 2023
susnuxforce-pushed
the
fix/legacy-files-list-sorting
branch
from
August 19, 2023 12:47
e79509a to
5a20f0fCompareThe sorting was not saved since files2vue changes in Nextcloud 27, as a new API endpoint was introduced and the old one was dropped without adjusting the legacy file list to use it. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnuxforce-pushed
the
fix/legacy-files-list-sorting
branch
from
August 19, 2023 13:08
5a20f0f to
cb5c172Compare8 tasks
The backport to stable27 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable27
git pull origin stable27
# Create the new backport branch
git checkout -b fix/foo-stable27
# Cherry pick the change from the commit sha1 of the change against the default branch# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The sorting was not saved since files2vue changes in Nextcloud 27, as a new API endpoint was introduced and the old one was dropped without adjusting the legacy file list to use it.
Checklist