Skip to content

Refactor userـldap app commands - #39928

Merged
come-nc merged 2 commits into
nextcloud:masterfrom
fsamapoor:refactor_user_ldap_app_commands
Feb 6, 2024
Merged

Refactor userـldap app commands#39928
come-nc merged 2 commits into
nextcloud:masterfrom
fsamapoor:refactor_user_ldap_app_commands

Conversation

@fsamapoor

@fsamapoorfsamapoor commented Aug 17, 2023

Copy link
Copy Markdown
Member

Summary

I have made some adjustments to the apps/user_ldap/lib/Command classes to improve the code readability.

The improvements in this PR include but are not limited to:

  • Using PHP8's constructor property promotion
  • Adding return types
  • Replacing return code integers with more readable strings.
  • Using early returns

Checklist

@fsamapoor
fsamapoorforce-pushed the refactor_user_ldap_app_commands branch from 2a9e9a7 to 9215858CompareAugust 17, 2023 08:55
@fsamapoorfsamapoor added 3. to review Waiting for reviews technical debt 🧱 🤔🚀 labels Aug 22, 2023
@fsamapoorfsamapoor added this to the Nextcloud 28 milestone Aug 22, 2023
@fsamapoor
fsamapoor requested review from a team, ArtificialOwl, blizzz and nfebe and removed request for a teamAugust 22, 2023 06:31
nfebe
nfebe reviewed Aug 27, 2023
View reviewed changes
Comment threadapps/user_ldap/lib/Command/CreateEmptyConfig.php
nfebe
nfebe reviewed Aug 27, 2023
View reviewed changes
Comment threadapps/user_ldap/lib/Command/ResetUser.php
nfebe
nfebe reviewed Aug 27, 2023
View reviewed changes

@nfebenfebe left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like some void-annotated methods do actually return values?

@fsamapoor

fsamapoor commented Aug 28, 2023

Copy link
Copy Markdown
MemberAuthor

Looks like some void-annotated methods do actually return values?

Hello @fenn-cs, Thank you for reviewing the PR.

No method with the return type of void returns any values. The git diff seems like the return belongs to the method with a void return type, but it actually does not.

These two lines do not belong to the same method:

image

Here is the expanded diff:

image

nfebe
nfebe approved these changes Aug 28, 2023
View reviewed changes

@nfebenfebe left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Faraz!

@skjnldsvskjnldsv mentioned this pull request Nov 1, 2023
Merged
This was referenced Nov 6, 2023
Merged
Merged
This was referenced Nov 14, 2023
Merged
Merged
@blizzzblizzz modified the milestones: Nextcloud 28, Nextcloud 29Nov 23, 2023
@blizzz
blizzzforce-pushed the refactor_user_ldap_app_commands branch from 9215858 to e46d750CompareJanuary 19, 2024 16:15
@blizzzblizzz added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 19, 2024
@blizzz
blizzz requested a review from come-ncJanuary 19, 2024 16:15
come-nc
come-nc reviewed Jan 22, 2024
View reviewed changes

@come-nccome-nc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m not sure why there is so much hate towards else statements, I find things clearer with them that without. Especially the continue in the loop instead of a simple else looks convoluted.
I like the strong typing, constructor promotion and constant usage in returns though.

Please revert at least the match (true).

Comment threadapps/user_ldap/lib/Command/Search.php Outdated
Comment threadapps/user_ldap/lib/Command/UpdateUUID.php Outdated
@fsamapoor
fsamapoorforce-pushed the refactor_user_ldap_app_commands branch from e46d750 to b7e19afCompareJanuary 24, 2024 07:39
@fsamapoor

fsamapoor commented Jan 24, 2024

Copy link
Copy Markdown
MemberAuthor

I’m not sure why there is so much hate towards else statements, I find things clearer with them that without. Especially the continue in the loop instead of a simple else looks convoluted. I like the strong typing, constructor promotion and constant usage in returns though.

Please revert at least the match (true).

Thank you for taking the time to review the changes Come. This was one of my older PRs and I appreciate your suggestions.

github-advanced-security[bot]
github-advanced-securityAI found potential problems Jan 24, 2024
View reviewed changes
Comment threadapps/user_ldap/lib/Command/Search.php Fixed
Comment threadapps/user_ldap/lib/Command/Search.php Fixed
@come-nc
come-ncforce-pushed the refactor_user_ldap_app_commands branch from b7e19af to 30c0567CompareJanuary 30, 2024 08:36
come-nc
come-nc approved these changes Jan 30, 2024
View reviewed changes
Comment threadapps/user_ldap/lib/Command/Search.php Outdated
@come-nc
come-ncforce-pushed the refactor_user_ldap_app_commands branch from 2785151 to 46e2cefCompareFebruary 1, 2024 16:39
@fsamapoor
fsamapoorforce-pushed the refactor_user_ldap_app_commands branch from 46e2cef to eca25b4CompareFebruary 5, 2024 08:03
fsamapoorand others added 2 commits February 6, 2024 10:02
@fsamapoor@come-nc
Refactors user_ldap app commands.
f03781b
To improve code readability.
Signed-off-by: Faraz Samapoor <f.samapoor@gmail.com>
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
@fsamapoor@come-nc
Update apps/user_ldap/lib/Command/Search.php
e6a4ebc
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Faraz Samapoor <f.samapoor@gmail.com>
@come-nc
come-ncforce-pushed the refactor_user_ldap_app_commands branch from eca25b4 to e6a4ebcCompareFebruary 6, 2024 09:02
@come-nc
come-nc merged commit ee6a62a into nextcloud:masterFeb 6, 2024
@fsamapoor
fsamapoor deleted the refactor_user_ldap_app_commands branch February 6, 2024 12:40
@blizzzblizzz mentioned this pull request Mar 5, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blizzzblizzzblizzz approved these changes
@nfebenfebenfebe approved these changes
@come-nccome-nccome-nc approved these changes
@ArtificialOwlArtificialOwlAwaiting requested review from ArtificialOwlArtificialOwl is a code owner automatically assigned from nextcloud/server-backend

Assignees

No one assigned

Labels

4. to releaseReady to be released and/or waiting for tests to finishtechnical debt🧱 🤔🚀

Projects

None yet

Milestone

Nextcloud 29

Development

Successfully merging this pull request may close these issues.

5 participants

@fsamapoor@blizzz@nfebe@github-advanced-security@come-nc