Uh oh!
There was an error while loading. Please reload this page.
[stable25] fix: don't emit Hooks when hookpaths are empty - #39936
Merged
Conversation
miaulalala
requested review from
ArtificialOwl, blizzz and nfebe
and removed request for
a teamAugust 17, 2023 13:10
miaulalala
commented
Aug 17, 2023
ContributorAuthor
linter is giving me 905 files lol |
miaulalala
commented
Aug 18, 2023
ContributorAuthor
Failing test is unrelated (acceptance-users) : |
max-nextcloud
approved these changes
Aug 18, 2023
icewind1991
approved these changes
Aug 18, 2023
miaulalalaforce-pushed
the
fix/stable25/transfer-ownership
branch
from
August 21, 2023 07:20
f89b6bd to
e84230fCompareContributor
php-cs check passed for another PR (#40008) - so i will try and rebase this so it runs again. |
max-nextcloudforce-pushed
the
fix/stable25/transfer-ownership
branch
from
August 28, 2023 09:07
e84230f to
8d0047fCompare
Comment on lines
+822
to
+833
| // moving a file/folder within the same mount point | ||
| // moving a file/folder within the same mount point | ||
| } elseif ($storage1 === $storage2) { | ||
| if ($storage1) { | ||
| $result = $storage1->rename($internalPath1, $internalPath2); | ||
| } else { | ||
| $result = false; | ||
| } | ||
| // moving a file/folder between storages (from $storage1 to $storage2) | ||
| // moving a file/folder between storages (from $storage1 to $storage2) |
Contributor
There was a problem hiding this comment.
Looks like the linter does not like this.
I'll move the comments into the respective block.
Signed-off-by: Anna Larch <anna@nextcloud.com> Signed-off-by: Max <max@nextcloud.com>
max-nextcloudforce-pushed
the
fix/stable25/transfer-ownership
branch
from
August 28, 2023 09:45
8d0047f to
1e957b5Comparemiaulalala
commented
Aug 28, 2023
ContributorAuthor
Thanks @max-nextcloud !!! Drone failure unrelated: |
max-nextcloud
commented
Aug 28, 2023
Contributor
Now if only someone could merge this despite the failing CI 🥺😉 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manual backport of #39481