Uh oh!
There was an error while loading. Please reload this page.
[stable27] encode filename trashbin restore - #40045
Merged
Merged
Conversation
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
kesselb
requested review from
ArtificialOwl, ChristophWurst, JuliaKirschenheuter, Pytal, artonge, come-nc, icewind1991, julien-nc, miaulalala, nfebe, nickvergessen, provokateurin, skjnldsv, st3iny, susnux, szaimen and tcitworld
as code ownersAugust 25, 2023 15:29
kesselb
commented
Aug 25, 2023
ContributorAuthor
Sorry everyone, that was the wrong base 🥳 😆 🙈 |
skjnldsv
approved these changes
Aug 25, 2023
artonge
approved these changes
Aug 25, 2023
susnux
approved these changes
Aug 25, 2023
Pytal
approved these changes
Aug 25, 2023
Merged
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manual backport of #39842
Summary
As per xhr.spec.whatwg.org/#the-setrequestheader()-method and infra.spec.whatwg.org/#byte-sequences the header value must be in the range 0x20 (SP) to 0x7E (~) hence we need to encode everything else.
TODO
Checklist