Uh oh!
There was an error while loading. Please reload this page.
Enable caldav push notifications by default - #40103
Merged
Merged
Conversation
hamza221
requested review from
ChristophWurst, miaulalala and tcitworld
as code ownersAugust 29, 2023 14:19
tcitworld
commented
Aug 29, 2023
Member
Reverting everything, not just changing the default value of the setting? |
hamza221
commented
Aug 29, 2023
ContributorAuthor
tcitworld
commented
Aug 29, 2023
Member
I don't understand how it answers #39158, sorry. :( |
hamza221
commented
Aug 30, 2023
ContributorAuthor
GretaD
approved these changes
Aug 31, 2023
GretaD
left a comment
Contributor
There was a problem hiding this comment.
i only checked the vue and js changes
miaulalala
approved these changes
Aug 31, 2023
hamza221force-pushed
the
enh/enable-caldav-push-notifications-by-default
branch
from
August 31, 2023 13:09
d84a49c to
5193cd5CompareChristophWurst
requested changes
Sep 6, 2023
| ?string $calendarDisplayName, | ||
| array $principalEmailAddresses, | ||
| array $users = []):void { | ||
| if ($this->config->getAppValue('dav', 'sendEventRemindersPush', 'no') !== 'yes') { |
There was a problem hiding this comment.
like @tcitworld said we should flip the default value but leave the option to turn the feature off
hamza221force-pushed
the
enh/enable-caldav-push-notifications-by-default
branch
from
September 8, 2023 14:32
5193cd5 to
c9e5dbdComparetcitworld
approved these changes
Sep 8, 2023
ChristophWurst
approved these changes
Sep 11, 2023
ChristophWurst
commented
Sep 11, 2023
Member
Failure of |
Signed-off-by: hamza221 <hamzamahjoubi221@gmail.com>
hamza221force-pushed
the
enh/enable-caldav-push-notifications-by-default
branch
from
September 12, 2023 11:58
4d778a7 to
823908bComparehamza221
enabled auto-merge
September 12, 2023 12:00
hamza221
deleted the
enh/enable-caldav-push-notifications-by-default
branch
September 13, 2023 08:50
ChristophWurst
commented
Feb 6, 2024
Member
Needs admin docs for how to set sendEventRemindersPush and an entry in the admin upgrade section for 28 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Checklist