Skip to content

don't believe sftp when it tells us the mtime is less than we know it is - #40105

Merged
susnux merged 1 commit into
masterfrom
sftp-known-mtime
Feb 6, 2025
Merged

don't believe sftp when it tells us the mtime is less than we know it is#40105
susnux merged 1 commit into
masterfrom
sftp-known-mtime

Conversation

@icewind1991

@icewind1991icewind1991 commented Aug 29, 2023

Copy link
Copy Markdown
Member

work around misbehaving sftp servers by keeping track of when we modify things

Comment threadapps/files_external/lib/Lib/Storage/SFTP.php Fixed
}
if (!$this->file_exists($path)) {
$this->getConnection()->put($this->absPath($path), '');
return $this->getConnection()->put($this->absPath($path), '');

Check notice

Code scanning / Psalm

InternalMethod

The method phpseclib\Net\SFTP::put is internal to phpseclib but called from OCA\Files_External\Lib\Storage\SFTP::touch
* provide access to SFTP servers.
*/
class SFTP extends \OC\Files\Storage\Common {
class SFTP extends \OC\Files\Storage\Common {

Check notice

Code scanning / Psalm

DeprecatedInterface

OCP\Files\Storage is marked deprecated
Comment threadapps/files_external/lib/Lib/Storage/SFTP.php Fixed
Comment threadapps/files_external/lib/Lib/Storage/SFTP.php Fixed
@solracsfsolracsf added this to the Nextcloud 28 milestone Nov 21, 2023
@blizzzblizzz mentioned this pull request Nov 22, 2023
5 tasks
@blizzzblizzz modified the milestones: Nextcloud 28, Nextcloud 29Nov 23, 2023
@skjnldsvskjnldsv added the 2. developing Work in progress label Feb 21, 2024
This was referenced Mar 12, 2024
@AltahrimAltahrim mentioned this pull request Mar 20, 2024
@icewind1991
icewind1991force-pushed the sftp-known-mtime branch 2 times, most recently from c6c07c0 to cdc4fa4CompareDecember 6, 2024 17:51
@icewind1991
icewind1991force-pushed the sftp-known-mtime branch 2 times, most recently from b8019e6 to 7aeabc9CompareDecember 16, 2024 14:09
@icewind1991
icewind1991 marked this pull request as ready for review December 16, 2024 15:42
@icewind1991
icewind1991 requested review from a team, ArtificialOwl, come-nc and nfebe and removed request for a teamDecember 20, 2024 17:53
@icewind1991icewind1991 added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Dec 20, 2024
@blizzzblizzz mentioned this pull request Jan 8, 2025
This was referenced Jan 14, 2025
This was referenced Jan 21, 2025
@blizzzblizzz mentioned this pull request Jan 29, 2025
1 task
@blizzzblizzz modified the milestones: Nextcloud 31, Nextcloud 32Jan 29, 2025
…ow it is
Signed-off-by: Robin Appelman <robin@icewind.nl>
@susnux
susnux merged commit 72e0bb7 into masterFeb 6, 2025
@susnux
susnux deleted the sftp-known-mtime branch February 6, 2025 01:21
@nextcloud-botnextcloud-bot mentioned this pull request Aug 19, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsbug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@icewind1991@susnux@github-advanced-security@come-nc@blizzz@solracsf@skjnldsv