Skip to content

feat: add switch to disable dns pinning - #40108

Merged
kesselb merged 1 commit into
masterfrom
bug/noid/config-dns-pinning
Aug 30, 2023
Merged

feat: add switch to disable dns pinning#40108
kesselb merged 1 commit into
masterfrom
bug/noid/config-dns-pinning

Conversation

@kesselb

@kesselbkesselb commented Aug 29, 2023

Copy link
Copy Markdown
Contributor

Summary

⚠️ One should not disable DNS pinning unless they know what they are doing

A hard requirement for DNS pinning is the ability to resolve DNS records.
If resolving DNS records is not possible, DNS pinning cannot work.

HTTP proxy => DNS names are resolved via proxy (c.f. https://everything.curl.dev/libcurl/proxies#local-or-proxy-name-lookuphttps://everything.curl.dev/transfers/conn/proxies.html#proxy-types). That explains, why outgoing connections work without the possibility to resolve DNS records locally.

TODO

  • CI

Checklist

@kesselbkesselb self-assigned this Aug 29, 2023
@kesselbkesselb added 3. to review Waiting for reviews bug labels Aug 29, 2023
@kesselbkesselb added this to the Nextcloud 28 milestone Aug 29, 2023
@kesselb

Copy link
Copy Markdown
ContributorAuthor

/backport to stable27

@kesselb

Copy link
Copy Markdown
ContributorAuthor

/backport to stable26

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
@kesselb
kesselbforce-pushed the bug/noid/config-dns-pinning branch from a186682 to eab46bdCompareAugust 29, 2023 16:04
@szaimen

This comment was marked as resolved.

@kesselb

This comment was marked as resolved.

@szaimen

This comment was marked as resolved.

@AltahrimAltahrim left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit sad to come to this, but I don't have a better solution for now ^^

@kesselb
kesselb merged commit ec089cf into masterAug 30, 2023
@kesselb
kesselb deleted the bug/noid/config-dns-pinning branch August 30, 2023 12:55
@backportbot-nextcloud

Copy link
Copy Markdown

The backport to stable26 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable26
git pull origin stable26
# Create the new backport branch
git checkout -b fix/foo-stable26
# Cherry pick the change from the commit sha1 of the change against the default branch# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable26

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@mgallien

Copy link
Copy Markdown
Contributor

/backport to stable25

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsbug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@kesselb@szaimen@mgallien@nickvergessen@Altahrim