Uh oh!
There was an error while loading. Please reload this page.
feat: add switch to disable dns pinning - #40108
Merged
Merged
Conversation
kesselb
commented
Aug 29, 2023
ContributorAuthor
/backport to stable27 |
kesselb
commented
Aug 29, 2023
ContributorAuthor
/backport to stable26 |
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
kesselbforce-pushed
the
bug/noid/config-dns-pinning
branch
from
August 29, 2023 16:04
a186682 to
eab46bdCompare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Altahrim
approved these changes
Aug 30, 2023
Altahrim
left a comment
Collaborator
There was a problem hiding this comment.
A bit sad to come to this, but I don't have a better solution for now ^^
nickvergessen
approved these changes
Aug 30, 2023
The backport to stable26 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable26
git pull origin stable26
# Create the new backport branch
git checkout -b fix/foo-stable26
# Cherry pick the change from the commit sha1 of the change against the default branch# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable26More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
8 tasks
mgallien
commented
Nov 29, 2023
Contributor
/backport to stable25 |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A hard requirement for DNS pinning is the ability to resolve DNS records.
If resolving DNS records is not possible, DNS pinning cannot work.
HTTP proxy => DNS names are resolved via proxy (c.f.
https://everything.curl.dev/libcurl/proxies#local-or-proxy-name-lookuphttps://everything.curl.dev/transfers/conn/proxies.html#proxy-types). That explains, why outgoing connections work without the possibility to resolve DNS records locally.TODO
Checklist