Uh oh!
There was an error while loading. Please reload this page.
Refactor OC\Server::getURLGenerator - #40128
Closed
summersab wants to merge 1 commit into
Closed
Conversation
summersab
requested review from
ChristophWurst, miaulalala, nickvergessen and st3iny
as code ownersAugust 30, 2023 01:25
summersabforce-pushed
the
refactor/OC-Server-getURLGenerator
branch
from
August 30, 2023 01:37
67553c0 to
8057c4cCompareSigned-off-by: Andrew Summers <18727110+summersab@users.noreply.github.com>
summersabforce-pushed
the
refactor/OC-Server-getURLGenerator
branch
from
August 30, 2023 02:33
8057c4c to
23f1beeCompare Merged
skjnldsv
commented
Feb 23, 2024
Member
conflicts |
This was referenced Mar 12, 2024
Merged
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the deprecated method
OC\Server::getURLGeneratorand replaces it withOC\Server::get(\OCP\IURLGenerator::class)throughout the entire NC codebase (excluding./appsand./3rdparty).Additionally, where necessary, the
\OCP\IURLGeneratorclass is imported via theusedirective.