Uh oh!
There was an error while loading. Please reload this page.
Refactor OC\Server::getHTTPClientService - #40137
Merged
skjnldsv merged 2 commits intoMay 30, 2024
Merged
Conversation
Signed-off-by: Andrew Summers <18727110+summersab@users.noreply.github.com>
summersabforce-pushed
the
refactor/OC-Server-getHTTPClientService
branch
from
August 30, 2023 02:30
9ac2b17 to
4536029Compare Merged
This was referenced Mar 12, 2024
Merged
Merged
Merged
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
skjnldsv
requested review from
a team, Altahrim, artonge and sorbaugh
and removed request for
a teamMay 30, 2024 12:22
skjnldsv
approved these changes
May 30, 2024
artonge
approved these changes
May 30, 2024
skjnldsv
enabled auto-merge
May 30, 2024 12:26
skjnldsv
disabled auto-merge
May 30, 2024 12:37
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the deprecated method
OC\Server::getGroupManagerand replaces it withOC\Server::get(\OCP\IGroupManager::class)throughout the entire NC codebase (excluding./appsand./3rdparty).Additionally, where necessary, the
\OCP\IGroupManagerclass is imported via theusedirective.