Uh oh!
There was an error while loading. Please reload this page.
Comment field fixes - #40173
Conversation
Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com>
Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com>
skjnldsv
left a comment
There was a problem hiding this comment.
I think that require a fix on the vue component directly
Setting a position: relative; on the .rich-contenteditable__input seems to do the trick and wrap the placeholder.
jancborchardt
left a comment
There was a problem hiding this comment.
Visually looks good to me, but it would be best to use variables instead of fixed values here, based on var(--default-grid-baseline) (4px).
@Jerome-Herbinet a quick general note regarding reopening pull requests – it's always nicer to keep it in the existing pull request (stuff can be force pushed or rebased for example), because otherwise reviews are spread among multiple pull requests. And if you do absolutely need to do a new PR, make sure to delete the branch of the old one. :)
Jerome-Herbinet
commented
Aug 31, 2023
OK @jancborchardt I understand, and I'll delete all my closed PRs' branches. |
skjnldsv
commented
Feb 24, 2024
Fixed with 28 and the new activity/comments merge |
Respawn of #38501 (avoids conflicts of old PR and more complete fix)
Testing from reviewers needed.
Fixes :
Before
Capture.video.du.31-08-2023.10.51.47.webm
After
Capture.video.du.31-08-2023.10.52.10.webm
Checklist