Uh oh!
There was an error while loading. Please reload this page.
feat(files): add sharing icon in header - #40192
Conversation
Uh oh!
There was an error while loading. Please reload this page.
28b3070 to
52590a7Compare7f04a0a to
6a91fa3Compare
This comment was marked as resolved.
This comment was marked as resolved.
@szaimen Feel free to open an issue, but for now this is feature parity. EDIT: Unless you can get to an agreement with the design team before it's merged. |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
6a91fa3 to
088a382Compareskjnldsv
commented
Sep 1, 2023
Here you go, we now have exactly what we had on the old files app. |
szaimen
commented
Sep 1, 2023
I created #40202 |
I tested this and the icon does not seem to directly update after I shared the folder for example. I guess this should be the case though? Apart from that seems to work well so good work! |
skjnldsv
commented
Sep 1, 2023
Needs a separate fix. We'll need to do a pass on global events. But right now the Sidebar doesn't update the files store, you are correct :) |
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
088a382 to
2592568Compareszaimen
commented
Sep 4, 2023
Shall I create a follow-up issue then? |
lhsazevedo
left a comment
There was a problem hiding this comment.
Working well for me as well
szaimen
commented
Sep 4, 2023
I've created #40263 |
Uh oh!
There was an error while loading. Please reload this page.