Skip to content

fix: prevent sharing permissions on user root folder - #40195

Merged
skjnldsv merged 1 commit into
masterfrom
fix/defaultpermissions-rootfolder
Sep 4, 2023
Merged

fix: prevent sharing permissions on user root folder#40195
skjnldsv merged 1 commit into
masterfrom
fix/defaultpermissions-rootfolder

Conversation

@skjnldsv

@skjnldsvskjnldsv commented Sep 1, 2023

Copy link
Copy Markdown
Member

A user root folder is not shareable.

server/lib/private/Share20/Manager.php

Lines 274 to 282 in 825b65e

// And you cannot share your rootfolder
if ($this->userManager->userExists($share->getSharedBy())) {
$userFolder = $this->rootFolder->getUserFolder($share->getSharedBy());
} else {
$userFolder = $this->rootFolder->getUserFolder($share->getShareOwner());
}
if ($userFolder->getId() === $share->getNode()->getId()) {
thrownew \InvalidArgumentException('You cannot share your root folder');
}

@skjnldsv
fix: prevent sharing permissions on user root folder
750a9f2
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@skjnldsvskjnldsv added bug 2. developing Work in progress labels Sep 1, 2023
@skjnldsvskjnldsv added this to the Nextcloud 28 milestone Sep 1, 2023
@skjnldsvskjnldsv self-assigned this Sep 1, 2023
@skjnldsv

skjnldsv commented Sep 1, 2023

Copy link
Copy Markdown
MemberAuthor

/backport to stable27

@skjnldsv

skjnldsv commented Sep 1, 2023

Copy link
Copy Markdown
MemberAuthor

/backport to stable26

@skjnldsv
skjnldsv requested review from a team, ArtificialOwl, come-nc, icewind1991, nickvergessen and sorbaugh and removed request for a teamSeptember 1, 2023 12:08
@skjnldsvskjnldsv added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Sep 1, 2023
@skjnldsv
skjnldsv merged commit db19b25 into masterSep 4, 2023
@skjnldsv
skjnldsv deleted the fix/defaultpermissions-rootfolder branch September 4, 2023 08:43
This was referenced Sep 4, 2023
Merged
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@icewind1991icewind1991icewind1991 approved these changes
@come-nccome-nccome-nc approved these changes
@ArtificialOwlArtificialOwlAwaiting requested review from ArtificialOwlArtificialOwl is a code owner automatically assigned from nextcloud/server-backend
@sorbaughsorbaughAwaiting requested review from sorbaughsorbaugh is a code owner automatically assigned from nextcloud/server-backend
@nickvergessennickvergessenAwaiting requested review from nickvergessen

Assignees

@skjnldsvskjnldsv

Labels

3. to reviewWaiting for reviewsbug

Projects

Files to vue
Status: Done

Milestone

Nextcloud 28

Development

Successfully merging this pull request may close these issues.

3 participants

@skjnldsv@icewind1991@come-nc