Skip to content

[stable25] Detect aborted connection in OC\Files\View and stop writing data to the output buffer - #40233

Merged
blizzz merged 3 commits into
stable25from
fix/fix-video-seeking-public-link
Sep 5, 2023
Merged

[stable25] Detect aborted connection in OC\Files\View and stop writing data to the output buffer#40233
blizzz merged 3 commits into
stable25from
fix/fix-video-seeking-public-link

Conversation

@come-nc

@come-nccome-nc commented Sep 4, 2023

Copy link
Copy Markdown
Contributor

Summary

When reading a video through a public link, and moving the time picker to different times in the video, each request keeps running after being aborted by the web browser and that overloads the server.
This is not the same as sabre-io/http#207 because in this case the download does not go through dav.

Checklist

 output buffer
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nccome-nc added the 3. to review Waiting for reviews label Sep 4, 2023
@come-nccome-nc added this to the Nextcloud 25.0.11 milestone Sep 4, 2023
@come-nccome-nc self-assigned this Sep 4, 2023
@come-nc
come-ncforce-pushed the fix/fix-video-seeking-public-link branch from 4f9a3de to fe766dcCompareSeptember 4, 2023 14:41
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
come-ncforce-pushed the fix/fix-video-seeking-public-link branch from fe766dc to 168b07dCompareSeptember 4, 2023 14:45
@come-nc
come-nc requested review from a team, AndyScherzinger, ArtificialOwl, nfebe and sorbaugh and removed request for a teamSeptember 4, 2023 14:54
@come-nc

Copy link
Copy Markdown
ContributorAuthor

/backport to stable26

@come-nc

Copy link
Copy Markdown
ContributorAuthor

/backport to stable27

@come-nc

Copy link
Copy Markdown
ContributorAuthor

/backport to master

Comment threadlib/private/Files/View.php Outdated
Comment threadlib/private/Files/View.php Outdated
Comment threadlib/private/Files/View.php Outdated
Comment threadlib/private/Files/View.php
Comment threadlib/private/Files/View.php Outdated
Co-authored-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
Signed-off-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
come-ncforce-pushed the fix/fix-video-seeking-public-link branch from aef1115 to 6b2580dCompareSeptember 5, 2023 12:36
@blizzzblizzz mentioned this pull request Sep 5, 2023
@blizzzblizzz removed the 3. to review Waiting for reviews label Sep 5, 2023
@blizzzblizzz added the 4. to release Ready to be released and/or waiting for tests to finish label Sep 5, 2023
@blizzz
blizzz merged commit cb607b5 into stable25Sep 5, 2023
@blizzz
blizzz deleted the fix/fix-video-seeking-public-link branch September 5, 2023 16:54
@backportbot-nextcloud

Copy link
Copy Markdown

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin stable27
# Create the new backport branch
git checkout -b fix/foo-stable27
# Cherry pick the change from the commit sha1 of the change against the default branch# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@backportbot-nextcloud

Copy link
Copy Markdown

The backport to master failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout master
git pull origin master
# Create the new backport branch
git checkout -b fix/foo-master
# Cherry pick the change from the commit sha1 of the change against the default branch# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-master

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to releaseReady to be released and/or waiting for tests to finishbugperformance 🚀

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@come-nc@AndyScherzinger@blizzz@Altahrim@joshtrichards