Uh oh!
There was an error while loading. Please reload this page.
fix(caldav): add webroot to objectid for activities - #40301
Merged
Conversation
kesselb
commented
Sep 6, 2023
ContributorAuthor
/backport to stable27 |
kesselb
commented
Sep 6, 2023
ContributorAuthor
/backport to stable26 |
tcitworld
approved these changes
Sep 7, 2023
tcitworld
left a comment
Member
There was a problem hiding this comment.
Do you mind adding a check that getWebroot() is called in EventTest.php::testGenerateObjectParameter?
ChristophWurst
approved these changes
Sep 7, 2023
miaulalala
approved these changes
Sep 7, 2023
kesselbforce-pushed
the
bug/noid/webroot-calendar-events-activity
branch
from
September 7, 2023 15:38
a6a68c8 to
19d18efCompareA calendar uri includes the webroot: example.com/cloud/remote.php/dav/calendars/alice/personal/ The calendar app uses base64(calendar uri) as identifier for calendar objects. Without this patch the links from activity app to calendar app don't work for installations in a subdirectory. Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
kesselbforce-pushed
the
bug/noid/webroot-calendar-events-activity
branch
from
September 13, 2023 18:33
19d18ef to
457f4a5CompareChristophWurst
approved these changes
Sep 13, 2023
ChristophWurst
deleted the
bug/noid/webroot-calendar-events-activity
branch
September 13, 2023 19:20
This was referenced Sep 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A calendar uri includes the webroot: example.com/cloud/remote.php/dav/calendars/alice/personal/
The calendar app uses base64(calendar uri) as identifier for calendar objects.
Without this patch the links from activity app to calendar app don't work for installations in a subdirectory.
TODO
Checklist