Skip to content

[stable23] fix(ratelimit): Only use memory cache backend for redis - #40307

Merged
blizzz merged 1 commit into
stable23from
backport/stable23/40293
Sep 7, 2023
Merged

[stable23] fix(ratelimit): Only use memory cache backend for redis#40307
blizzz merged 1 commit into
stable23from
backport/stable23/40293

Conversation

@miaulalala

@miaulalalamiaulalala commented Sep 6, 2023

Copy link
Copy Markdown
Contributor

Manual backport of #40293

@nickvergessen@miaulalala
fix(ratelimit): Only use memory cache backend for redis
0fe4672
Signed-off-by: Anna Larch <anna@nextcloud.com>
@miaulalala
miaulalala requested review from a team, ArtificialOwl, come-nc and sorbaugh and removed request for a teamSeptember 6, 2023 16:49
@miaulalalamiaulalala self-assigned this Sep 6, 2023
@miaulalalamiaulalala added bug 3. to review Waiting for reviews labels Sep 6, 2023
@miaulalala

miaulalala commented Sep 7, 2023

Copy link
Copy Markdown
ContributorAuthor

Failing test is samba:


Runtime: PHP 7.4.21
--
41 | Configuration: /drone/src/tests/phpunit-autotest-external.xml
42 | Error: No code coverage driver is available

@miaulalalamiaulalala added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Sep 7, 2023
@blizzz
blizzz merged commit 323c2d8 into stable23Sep 7, 2023
@blizzz
blizzz deleted the backport/stable23/40293 branch September 7, 2023 07:15
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@juliusknorrjuliusknorrjuliusknorr approved these changes
@skjnldsvskjnldsvskjnldsv approved these changes
@ArtificialOwlArtificialOwlAwaiting requested review from ArtificialOwlArtificialOwl was automatically assigned from nextcloud/server-backend
@sorbaughsorbaughAwaiting requested review from sorbaughsorbaugh was automatically assigned from nextcloud/server-backend
@come-nccome-ncAwaiting requested review from come-nccome-nc was automatically assigned from nextcloud/server-backend

Assignees

@miaulalalamiaulalala

Labels

4. to releaseReady to be released and/or waiting for tests to finishbug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@miaulalala@juliusknorr@skjnldsv@blizzz@nickvergessen