Uh oh!
There was an error while loading. Please reload this page.
[stable27] Backport Polish new sharing flow : accesibility, expand bahavior, click outside behaviour - #40327
Merged
Merged
Conversation
nfebeforce-pushed
the
manual/backport/stable27/40266
branch
from
September 7, 2023 11:40
393bd24 to
e361ea6Compareblizzz
commented
Sep 7, 2023
Member
Please add milestone and labels when opening a PR :) |
AndyScherzinger
commented
Sep 7, 2023
Member
/compile |
blizzz
commented
Sep 7, 2023
Member
/compile / |
blizzz
requested review from
a team, Pytal, artonge, juliusknorr, sorbaugh and szaimen
and removed request for
a teamSeptember 7, 2023 12:50
Currently, swithcing between permissions in the sharing permissions details view would toggle the custom permissions view. We think, it's better for the custom permission option to simple expand the custom permissions view and never close it gain even if the user is switching between bundled permissions. The user can always collapse the view by using the "Advanced settings" toggle. Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
If a user clicks anywhere outside of the quickshare dropdown, it should be closed. Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
- Adds appropriate aria attributes - Uses button element for dropdown items as it's more semantically correct - Uses trap-focus lib to trap focus when the drowpdown is active - Adds custom handling for arrow up and down Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
blizzzforce-pushed
the
manual/backport/stable27/40266
branch
from
September 7, 2023 13:19
fc70eb3 to
1539d5eCompareblizzz
commented
Sep 7, 2023
Member
/compile / |
blizzz
commented
Sep 7, 2023
Member
Tests were all satisfactory, only need to rebuild assets → can merge when they were compiled |
AndyScherzinger
approved these changes
Sep 7, 2023
juliusknorr
approved these changes
Sep 7, 2023
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manual backport : #40266