Skip to content

[stable23] Hide shares by disabled users - #40332

Merged
sorbaugh merged 4 commits into
stable23from
backport/39699/stable23
Feb 27, 2024
Merged

[stable23] Hide shares by disabled users#40332
sorbaugh merged 4 commits into
stable23from
backport/39699/stable23

Conversation

@come-nc

@come-nccome-nc commented Sep 7, 2023

Copy link
Copy Markdown
Contributor

Manual backport of #39699

@come-nccome-nc self-assigned this Sep 7, 2023
github-advanced-security[bot]
github-advanced-securityAI found potential problems Sep 7, 2023
View reviewed changes
Comment threadlib/private/Share20/Manager.php Fixed
Comment threadlib/private/Share20/Manager.php Fixed
Comment threadlib/private/Share20/Manager.php Fixed
@blizzz

blizzz commented Dec 14, 2023

Copy link
Copy Markdown
Member

what is the outlook here?

@come-nc
come-ncforce-pushed the backport/39699/stable23 branch from a5e9a31 to 6be8552CompareDecember 14, 2023 15:46
@come-nc
come-nc marked this pull request as ready for review December 14, 2023 15:47
@come-nccome-nc added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Dec 14, 2023
@come-nc
come-nc requested review from a team, Altahrim, icewind1991 and nfebe and removed request for a teamDecember 14, 2023 15:52
@blizzz

blizzz commented Jan 24, 2024

Copy link
Copy Markdown
Member

@come-nc do we still need it?

@come-nc
come-ncforce-pushed the backport/39699/stable23 branch from 6be8552 to ec95152CompareJanuary 29, 2024 13:00
@come-nc

come-nc commented Feb 1, 2024

Copy link
Copy Markdown
ContributorAuthor

@come-nc do we still need it?

Yes, can I force merge? I believe freeze is over?

@come-nc

come-nc commented Feb 22, 2024

Copy link
Copy Markdown
ContributorAuthor

/backport! to stable24

@backportbotbackportbotBot mentioned this pull request Feb 22, 2024
Merged
@come-nc

come-nc commented Feb 22, 2024

Copy link
Copy Markdown
ContributorAuthor

/backport! to stable25

@backportbotbackportbotBot mentioned this pull request Feb 22, 2024
Merged
2 tasks
@come-nc@AndyScherzinger
Set files_sharing:hide_disabled_user_shares to 'yes' to hide shares f…
603c0d0
…rom disabled users
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
come-ncand others added 3 commits February 26, 2024 10:42
@come-nc@AndyScherzinger
Fix tests, add test for the new feature
3e80a03
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc@Altahrim@AndyScherzinger
Use nullsafe call syntax instead of additionnal check
0ee5c61
Co-authored-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
Signed-off-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
@come-nc@AndyScherzinger
Remove modern PHP syntax, and apply codesniffer fixes in Share20/Mana…
1fb72e8
…ger.php
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nccome-nc added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Feb 26, 2024
@sorbaugh
sorbaugh merged commit 941dee9 into stable23Feb 27, 2024
@sorbaugh
sorbaugh deleted the backport/39699/stable23 branch February 27, 2024 14:54
@AndyScherzinger

AndyScherzinger commented Feb 28, 2024

Copy link
Copy Markdown
Member

#39699

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blizzzblizzzblizzz approved these changes
@AltahrimAltahrimAltahrim approved these changes
@icewind1991icewind1991Awaiting requested review from icewind1991icewind1991 was automatically assigned from nextcloud/server-backend
@nfebenfebeAwaiting requested review from nfebenfebe was automatically assigned from nextcloud/server-backend

Assignees

@come-nccome-nc

Labels

4. to releaseReady to be released and/or waiting for tests to finishenhancementfeature: sharingfeature: users and groups

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@come-nc@blizzz@AndyScherzinger@Altahrim@github-advanced-security@sorbaugh