Skip to content

40172 polish sharing flow bugs - #40372

Merged
nfebe merged 3 commits into
masterfrom
40172-polish-sharing-flow-bugs
Sep 12, 2023
Merged

40172 polish sharing flow bugs#40372
nfebe merged 3 commits into
masterfrom
40172-polish-sharing-flow-bugs

Conversation

@nfebe

Copy link
Copy Markdown
Contributor

Resolves : #40172

@nfebe
nfebeforce-pushed the 40172-polish-sharing-flow-bugs branch from 3b503bd to 0e4e782CompareSeptember 11, 2023 20:19
Comment threadapps/files_sharing/lib/Listener/LoadSidebarListener.php Fixed
Comment threadapps/files_sharing/lib/Listener/LoadSidebarListener.php
@nfebe
nfebeforce-pushed the 40172-polish-sharing-flow-bugs branch from 71f88e0 to 9ff9390CompareSeptember 12, 2023 11:31
Comment threadapps/files_sharing/lib/Listener/LoadSidebarListener.php Fixed
Comment threadapps/files_sharing/lib/Listener/LoadSidebarListener.php Fixed
Comment threadapps/files_sharing/lib/Listener/LoadSidebarListener.php Fixed
@nfebe
nfebeforce-pushed the 40172-polish-sharing-flow-bugs branch 2 times, most recently from 0ed74d6 to d5fce36CompareSeptember 12, 2023 11:41
@nfebenfebe added this to the Nextcloud 27.1.0 milestone Sep 12, 2023
Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
Use the the modern intial-state library to pass data about
`allowPublicUploads` to the sharing frontend.
Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
@nfebe
nfebeforce-pushed the 40172-polish-sharing-flow-bugs branch from d5fce36 to 71b6d47CompareSeptember 12, 2023 19:51
@nfebe

Copy link
Copy Markdown
ContributorAuthor

/compile amend /

Delete button text should have same size as other buttons.
Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@nextcloud-command
nextcloud-commandforce-pushed the 40172-polish-sharing-flow-bugs branch from 5166f51 to 3d071abCompareSeptember 12, 2023 21:11
@nfebe
nfebe merged commit e94a83a into masterSep 12, 2023
@nfebe
nfebe deleted the 40172-polish-sharing-flow-bugs branch September 12, 2023 21:53
@nfebe

Copy link
Copy Markdown
ContributorAuthor

/backport to stable27

@backportbot-nextcloud

Copy link
Copy Markdown

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin stable27
# Create the new backport branch
git checkout -b fix/foo-stable27
# Cherry pick the change from the commit sha1 of the change against the default branch# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

1 similar comment
@backportbot-nextcloud

Copy link
Copy Markdown

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin stable27
# Create the new backport branch
git checkout -b fix/foo-stable27
# Cherry pick the change from the commit sha1 of the change against the default branch# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsfeature: sharing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

⛑️ Polishing for new sharing design and flow 🤝

6 participants

@nfebe@AndyScherzinger@juliusknorr@artonge@github-advanced-security@skjnldsv