Skip to content

Display user status by the side in sharing flow - #40393

Merged
blizzz merged 2 commits into
masterfrom
fix-user-status-sharing-flow
Sep 13, 2023
Merged

Display user status by the side in sharing flow#40393
blizzz merged 2 commits into
masterfrom
fix-user-status-sharing-flow

Conversation

@nfebe

Copy link
Copy Markdown
Contributor

The quick share drop down now takes the place where the user status would show in the past, so we have the option of removing it (as it's available in the profile dropdown) or putting it at the side as such.

It's put on the side without the icon, as the status icon appears on the avatar when set.

BeforeNow
Screenshot from 2023-09-13 11-32-46Screenshot from 2023-09-13 12-00-20

Comment threadapps/files_sharing/src/components/SharingEntry.vue Outdated
@nfebe

Copy link
Copy Markdown
ContributorAuthor

Updates that take into consideration disambiguation text as well as wrap. (Also blurred the text, just like the disambiguation text)

Without wrapWith wrap
Screenshot from 2023-09-13 15-07-07Screenshot from 2023-09-13 15-07-48

The quick share drop down now takes the place where the user status
would show in the past, so we have the option of removing it (as it's available
in the profile dropdown) or putting it at the side as such.
It's put on the side without the icon, as the status icon appears on the avatar
when set.
Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
@nfebe
nfebeforce-pushed the fix-user-status-sharing-flow branch from 32c4c01 to c0344a2CompareSeptember 13, 2023 14:19
@nfebe
nfebeforce-pushed the fix-user-status-sharing-flow branch from c0344a2 to 7d9b5b6CompareSeptember 13, 2023 14:34
Removes button from footer and removes button background.
Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
@AndyScherzinger

Copy link
Copy Markdown
Member

Looks good, just some minor issues as mentioned partially already

  • is Ellipsizing implemented?
  • text size of the parenthesis text is not yet unified, see status vs. mail address for example
  • is the grey tone accessible? Given the font size the contrast ratio needs to be 1:4,5 (relevant more for Master than stable27)

@nfebe
nfebeforce-pushed the fix-user-status-sharing-flow branch from 7d9b5b6 to 2b2622dCompareSeptember 13, 2023 14:43
@nfebe

Copy link
Copy Markdown
ContributorAuthor

is Ellipsizing implemented?

So no wrap? things wrap in a decent way when text is too long as shown in the last screen shots.

text size of the parenthesis text is not yet unified, see status vs. mail address for example
is the grey tone accessible? Given the font size the contrast ratio needs to be 1:4,5 (relevant more for Master than stable27)

color: var(--color-text-maxcontrast); is used.

cc: @AndyScherzinger

@jancborchardt

Copy link
Copy Markdown
Member

Sorry but with wrapping it looks way too wonky, we shouldn't do that. It needs to be ellipsized to one line. :)

Also, the gap between the first line and the permission line is too big for users. For "Share link" it looks good, but for the users below it's larger.

@AndyScherzinger

Copy link
Copy Markdown
Member

@fenn-cs Color value in use looks good 👍
Ellipsizing like mentioned by Jan, yeah, preferred to enforce single line for that part of the list item's data.

@nfebenfebe mentioned this pull request Sep 13, 2023
@blizzz
blizzz merged commit 80f3e46 into masterSep 13, 2023
@blizzz
blizzz deleted the fix-user-status-sharing-flow branch September 13, 2023 19:36
@nfebe

Copy link
Copy Markdown
ContributorAuthor

/backport to stable27

@backportbot-nextcloud

Copy link
Copy Markdown

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin stable27
# Create the new backport branch
git checkout -b fix/foo-stable27
# Cherry pick the change from the commit sha1 of the change against the default branch# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@nfebe@AndyScherzinger@jancborchardt@juliusknorr@blizzz@skjnldsv