Uh oh!
There was an error while loading. Please reload this page.
fix mimetype not being updated when changing file extention on objectstore - #40394
Merged
Conversation
icewind1991
requested review from
a team, ArtificialOwl, nfebe and sorbaugh
and removed request for
a teamSeptember 13, 2023 14:37
icewind1991
commented
Sep 13, 2023
MemberAuthor
/backport to stable27 |
icewind1991
commented
Sep 13, 2023
MemberAuthor
/backport to stable26 |
icewind1991
commented
Sep 13, 2023
MemberAuthor
/backport to stable25 |
come-nc
reviewed
Sep 21, 2023
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Merged
This was referenced Mar 12, 2024
Merged
Merged
Merged
skjnldsv
marked this pull request as draft
November 15, 2024 13:10
icewind1991force-pushed
the
updater-change-mimetype-objectstore
branch
from
December 5, 2024 17:01
4857c27 to
19105d1Compareicewind1991
marked this pull request as ready for review
December 5, 2024 17:01
…bject store Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991force-pushed
the
updater-change-mimetype-objectstore
branch
from
December 5, 2024 17:05
19105d1 to
3719977Compareicewind1991force-pushed
the
updater-change-mimetype-objectstore
branch
from
December 6, 2024 16:46
3400329 to
3719977Comparecome-nc
approved these changes
Dec 9, 2024
provokateurin
approved these changes
Dec 9, 2024
This was referenced Dec 11, 2024
solracsf
commented
Dec 11, 2024
Member
This is being backported to old versions, shouldn't 28/29/30 be backported too? 🤔 |
provokateurin
commented
Dec 11, 2024
Member
True, the original PR was just quite old |
provokateurin
commented
Dec 11, 2024
Member
/backport to stable30 |
provokateurin
commented
Dec 11, 2024
Member
/backport to stable29 |
provokateurin
commented
Dec 11, 2024
Member
/backport to stable28 |
This was referenced Dec 11, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With object store the source entry no longer exists once we hit the updater, so the old code path for changing the mimetype wasn't triggered.