Skip to content

Revert "Do not do redirect handling when loggin out" - #40407

Merged
sorbaugh merged 1 commit into
nextcloud:masterfrom
haslersn:revert-pr-12573
Jun 10, 2026
Merged

Revert "Do not do redirect handling when loggin out"#40407
sorbaugh merged 1 commit into
nextcloud:masterfrom
haslersn:revert-pr-12573

Conversation

@haslersn

@haslersnhaslersn commented Sep 14, 2023

Copy link
Copy Markdown
Contributor

This reverts commit 60e5a5e. That commit was only required due to "executionContext" which has since been removed. See: #16310

Checklist

@kesselbkesselb added 3. to review Waiting for reviews technical debt 🧱 🤔🚀 labels Sep 14, 2023
@kesselbkesselb added this to the Nextcloud 28 milestone Sep 14, 2023
@kesselb

kesselb commented Sep 14, 2023

Copy link
Copy Markdown
Contributor

Good finding 👍

@skjnldsvskjnldsv mentioned this pull request Nov 1, 2023
Merged
@haslersn

haslersn commented Nov 2, 2023

Copy link
Copy Markdown
ContributorAuthor

What's keeping this from getting merged?

@nickvergessen
nickvergessen requested review from kesselb and removed request for rullzerNovember 2, 2023 09:59
@kesselb

kesselb commented Nov 2, 2023

Copy link
Copy Markdown
Contributor

What's keeping this from getting merged?

The failing DCO check, for example.
Please rebase your branch (to pull in the latest changes from master) and sign off the commits (to pass the DCO check).

@haslersn

haslersn commented Nov 2, 2023

Copy link
Copy Markdown
ContributorAuthor

@kesselb is was signed off, but apparently there was a mismatch between committer email and sign-off email. Should be fixed now.

This was referenced Nov 6, 2023
Merged
Merged
This was referenced Nov 14, 2023
Merged
Merged
@blizzzblizzz modified the milestones: Nextcloud 28, Nextcloud 29Nov 23, 2023
@AltahrimAltahrim mentioned this pull request Mar 12, 2024
Merged
@haslersn

haslersn commented Mar 12, 2024

Copy link
Copy Markdown
ContributorAuthor

What's now keeping this from getting merged?

@come-nc

come-nc commented Mar 12, 2024

Copy link
Copy Markdown
Contributor

I rebased for CI, I do not understand enough about this for approving, I’ll follow @kesselb lead on this one.

@kesselb

kesselb commented Mar 13, 2024

Copy link
Copy Markdown
Contributor

Hello Hello, it's been a while and I don't remember all the details. I think the middleware was added to address the redirect cause by clear-site-data executionContext and can, as we removed executionContext again, go.

This was referenced Jan 14, 2026
Merged
Merged
@nextcloud-botnextcloud-bot mentioned this pull request Jan 22, 2026
Merged
This was referenced Jan 29, 2026
Merged
Merged
This was referenced Feb 11, 2026
Merged
Merged
@blizzzblizzz modified the milestones: Nextcloud 33, Nextcloud 34Feb 16, 2026
@DorraJaouad
DorraJaouad requested a review from a team as a code ownerApril 23, 2026 09:41
@DorraJaouad
DorraJaouad requested review from CarlSchwan and removed request for a teamApril 23, 2026 09:41
@nextcloud-botnextcloud-bot mentioned this pull request May 27, 2026
Merged
@nextcloud-botnextcloud-bot mentioned this pull request Jun 4, 2026
Closed
@skjnldsvskjnldsv mentioned this pull request Jun 4, 2026
Merged
This was referenced Jun 5, 2026
Merged
Merged
@susnuxsusnux added the community pull requests from community label Jun 9, 2026
@susnuxsusnux removed this from the Nextcloud 34.0.1 milestone Jun 9, 2026
@haslersn@susnux
revert: "Do not do redirect handling when loggin out"
8325e69
This reverts commit 60e5a5e.
That commit was only required due to "executionContext" which has
since been removed. See: nextcloud#16310
Signed-off-by: Sebastian Hasler <sebastian.hasler@stuvus.uni-stuttgart.de>
susnux
susnux approved these changes Jun 9, 2026
View reviewed changes

@susnuxsusnux left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased, otherwise looks fine

@susnuxsusnux added 3. to review Waiting for reviews and removed 2. developing Work in progress stale Ticket or PR with no recent activity labels Jun 10, 2026
@sorbaugh
sorbaugh merged commit 1cf3e36 into nextcloud:masterJun 10, 2026
185 of 197 checks passed
@welcome

welcomeBot commented Jun 10, 2026

Copy link
Copy Markdown

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

@nextcloud-botnextcloud-bot mentioned this pull request Aug 11, 2026
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@susnuxsusnuxsusnux approved these changes
@kesselbkesselbkesselb approved these changes
@ChristophWurstChristophWurstAwaiting requested review from ChristophWurst
@come-nccome-ncAwaiting requested review from come-nc
@nickvergessennickvergessenAwaiting requested review from nickvergessen
@ArtificialOwlArtificialOwlAwaiting requested review from ArtificialOwlArtificialOwl is a code owner automatically assigned from nextcloud/server-backend
@sorbaughsorbaughAwaiting requested review from sorbaughsorbaugh is a code owner automatically assigned from nextcloud/server-backend
@CarlSchwanCarlSchwanAwaiting requested review from CarlSchwanCarlSchwan is a code owner automatically assigned from nextcloud/server-backend

Assignees

No one assigned

Labels

3. to reviewWaiting for reviewscommunitypull requests from communitytechnical debt🧱 🤔🚀

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@haslersn@kesselb@come-nc@nickvergessen@susnux@joshtrichards@blizzz@skjnldsv@nextcloud-bot@sorbaugh