Uh oh!
There was an error while loading. Please reload this page.
fix: don't use davtags for tag search - #40418
Merged
Merged
Conversation
ChristophWurst
approved these changes
Sep 14, 2023
kesselb
commented
Sep 14, 2023
ContributorAuthor
/backport to stable27 |
kesselb
commented
Sep 14, 2023
ContributorAuthor
/backport to stable26 |
kesselb
commented
Sep 14, 2023
ContributorAuthor
/backport to stable25 |
marcelklehr
approved these changes
Sep 14, 2023
kesselbforce-pushed
the
fix/noid/dont-join-dav-tags
branch
from
September 15, 2023 10:17
da226d8 to
8395eb7Compare1. #26813 Initial implementation with support for systemtags and davtags (vcategory) 2. #39062 Additional check if the given tag exists, though ISystemTagManager.getAllTags only looks for systemtags Therefore it's not possible anymore to search for davtags and unnecessary to join the other tables. Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
kesselbforce-pushed
the
fix/noid/dont-join-dav-tags
branch
from
September 15, 2023 15:19
8395eb7 to
4c5e79dCompare
This was referenced Sep 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#26813 Initial implementation with support for systemtags and davtags (vcategory)
#39062 Additional check if the given tag exists, though ISystemTagManager.getAllTags only looks for systemtags
Therefore, it's not possible anymore to search for davtags and unnecessary to join the other tables.
TODO
Checklist