Uh oh!
There was an error while loading. Please reload this page.
Multiple bug fix in users list - #40428
Merged
Merged
Conversation
artonge
commented
Sep 14, 2023
Collaborator
- Do not display userCount when it is equal to 0
- Reset loading state on UserRow mount
- Do not preload potential manager list on UserRow mount
- Do not manipulate userCount when it is equal to 0
Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Louis Chemineau <louis@chmn.me>
artongeforce-pushed
the
artonge/fix/users_list_bugs
branch
from
September 14, 2023 14:19
6e98fe4 to
617a9e8ComparePytalforce-pushed
the
artonge/fix/users_list_bugs
branch
2 times, most recently
from
September 15, 2023 00:00
07a525f to
15d4a36CompareSigned-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Pytalforce-pushed
the
artonge/fix/users_list_bugs
branch
from
September 15, 2023 00:03
15d4a36 to
58229adComparePytal
commented
Sep 15, 2023
Member
Pushed a ux fix to show initial loading state of managers |
Pytal
approved these changes
Sep 15, 2023
artonge
enabled auto-merge
September 15, 2023 11:00
artonge
requested review from
a team, susnux and szaimen
and removed request for
a teamSeptember 15, 2023 11:00
susnux
approved these changes
Sep 15, 2023
come-nc
commented
Sep 18, 2023
Contributor
@Pytal Could you backport this to stable27? Not all commits will be needed I think but some of them applies the same I think. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.