Skip to content

fix(dav): report status - #40474

Merged
skjnldsv merged 1 commit into
masterfrom
fix/report-dav
Sep 18, 2023
Merged

fix(dav): report status#40474
skjnldsv merged 1 commit into
masterfrom
fix/report-dav

Conversation

@skjnldsv

@skjnldsvskjnldsv commented Sep 18, 2023

Copy link
Copy Markdown
Member

Fixed favorites and (incoming) tag view

Context

If a status is defined on the response, it will be used and forced-rendered outside of propstat. Which is invalid according to the RFC and broke in the last webdav update (which is now compliant to the rfc too)

https://github.com/nextcloud/3rdparty/blob/1269091e96a2a550912db37c0d2b29ed5c0aa60f/sabre/dav/lib/DAV/Xml/Element/Response.php#L115-L117

@skjnldsv
fix(dav): report status
63da44b
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
@skjnldsvskjnldsv added this to the Nextcloud 28 milestone Sep 18, 2023
@skjnldsv
skjnldsv requested review from a team and susnuxSeptember 18, 2023 09:32
@skjnldsvskjnldsv self-assigned this Sep 18, 2023
@skjnldsv
skjnldsv requested review from ArtificialOwl, icewind1991 and nfebe and removed request for a teamSeptember 18, 2023 09:32
@skjnldsvskjnldsv mentioned this pull request Sep 18, 2023
Merged
1 task
@skjnldsv
skjnldsv merged commit 9ea9743 into masterSep 18, 2023
@skjnldsv
skjnldsv deleted the fix/report-dav branch September 18, 2023 12:07
@susnux

susnux commented Sep 18, 2023

Copy link
Copy Markdown
Contributor

For reference: This one is a workaround for sabre-io/dav#1488

@skjnldsvskjnldsv mentioned this pull request Sep 18, 2023
Merged
@icewind1991

icewind1991 commented Sep 18, 2023

Copy link
Copy Markdown
Member

Tests meed updating?

There was 1 failure:
--
Failed asserting that null matches expected 200. --
/drone/src/apps/dav/tests/unit/Connector/Sabre/FilesReportPluginTest.php:445

@skjnldsv

skjnldsv commented Sep 18, 2023

Copy link
Copy Markdown
MemberAuthor

@icewind1991#40485

@skjnldsvskjnldsv mentioned this pull request Oct 25, 2023
Merged
@susnux

susnux commented Feb 21, 2024

Copy link
Copy Markdown
Contributor

/backport to stable27

@backportbotbackportbotBot mentioned this pull request Feb 21, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@icewind1991icewind1991icewind1991 approved these changes
@artongeartongeartonge approved these changes
@susnuxsusnuxAwaiting requested review from susnux
@ArtificialOwlArtificialOwlAwaiting requested review from ArtificialOwlArtificialOwl is a code owner automatically assigned from nextcloud/server-backend
@nfebenfebeAwaiting requested review from nfebenfebe is a code owner automatically assigned from nextcloud/server-backend

Assignees

@skjnldsvskjnldsv

Labels

3. to reviewWaiting for reviewsbugfeature: dav

Projects

None yet

Milestone

Nextcloud 28

Development

Successfully merging this pull request may close these issues.

4 participants

@skjnldsv@susnux@icewind1991@artonge