Uh oh!
There was an error while loading. Please reload this page.
add method to create a node from cache entry + mountpoint - #40478
Merged
Conversation
icewind1991
requested review from
a team, ArtificialOwl, nfebe and sorbaugh
and removed request for
a teamSeptember 18, 2023 13:11
Uh oh!
There was an error while loading. Please reload this page.
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991force-pushed
the
node-from-entry
branch
from
September 19, 2023 09:43
969bba2 to
5e34755Comparecome-nc
approved these changes
Sep 21, 2023
nickvergessen
approved these changes
Sep 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are cases[1] where we need an
INodebut we only have the cache entry and mountpoint.We can construct the needed "higher" classes from that data but the process is somewhat involved and uses a number of internal APIs. By exposing the functionality in the public API we can make it easy for apps to do.