Skip to content

fix: content info footer on guest pages - #40481

Merged
st3iny merged 1 commit into
masterfrom
fix/guest-pages-contentinfo
Sep 19, 2023
Merged

fix: content info footer on guest pages#40481
st3iny merged 1 commit into
masterfrom
fix/guest-pages-contentinfo

Conversation

@st3iny

@st3inyst3iny commented Sep 18, 2023

Copy link
Copy Markdown
Member
  • Resolves: none

Summary

The content info footer has no background on guest pages, e.g. 403.php or 404.php. I moved the custom styling from Login.vue to guest.scss so that every guest page benefits from it.

Error page (404.php)

BeforeAfter
login-beforelogin-after

Login page (should not change!)

BeforeAfter
grafiklogin-after

Checklist

@st3inyst3iny added this to the Nextcloud 28 milestone Sep 18, 2023
@st3inyst3iny self-assigned this Sep 18, 2023
@st3iny

Copy link
Copy Markdown
MemberAuthor

/backport to stable27

Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
@st3iny
st3inyforce-pushed the fix/guest-pages-contentinfo branch from 51aa1c4 to 9a5a392CompareSeptember 19, 2023 19:59
@st3iny
st3iny merged commit 7cf8421 into masterSep 19, 2023
@st3iny
st3iny deleted the fix/guest-pages-contentinfo branch September 19, 2023 21:54
@backportbot-nextcloud

Copy link
Copy Markdown

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin stable27
# Create the new backport branch
git checkout -b fix/foo-stable27
# Cherry pick the change from the commit sha1 of the change against the default branch# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsaccessibilitybugdesignDesign, UI, UX, etc.feature: accessibility

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants

@st3iny@susnux@artonge