Uh oh!
There was an error while loading. Please reload this page.
fix(comments): Use provided offset in best effort when loading comments - #40488
Merged
nickvergessen merged 1 commit intoSep 19, 2023
Merged
Conversation
When we didn't find the "$lastKnownComment" the whole condition was ignored. Now we still use the ID as an offset. This is required as a fall-back for expired messages in Talk and deleted comments in other apps. Signed-off-by: Joas Schilling <coding@schilljs.com>
4 tasks
nickvergessen
commented
Sep 18, 2023
MemberAuthor
/backport to stable27 |
nickvergessen
commented
Sep 18, 2023
MemberAuthor
/backport to stable26 |
nickvergessen
commented
Sep 18, 2023
MemberAuthor
/backport to stable25 |
marcelklehr
approved these changes
Sep 18, 2023
nickvergessen
enabled auto-merge
September 18, 2023 20:00
nickvergessen
disabled auto-merge
September 19, 2023 13:30
nickvergessen
deleted the
bugfix/noid/message-expiration-breaks-pagination
branch
September 19, 2023 13:30
This was referenced Sep 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we didn't find the "$lastKnownComment" the whole condition was ignored. Now we still use the ID as an offset.
This is required as a fall-back for expired messages in Talk and deleted comments in other apps.
Checklist